[v5.15] possible deadlock in ext4_move_extents (4)

Hello,

syzbot found the following issue on:

HEAD commit: c16c81c81336 Linux 5.15.178
git tree: linux-5.15.y
console output: https://syzkaller.appspot.com/x/log.txt?x=161ecb24580000
kernel config: https://syzkaller.appspot.com/x/.config?x=d302c69e93fb6774
dashboard link: https://syzkaller.appspot.com/bug?extid=64797b288ec15d559468
compiler: Debian clang version 15.0.6, GNU ld (GNU Binutils for Debian) 2.40

Unfortunately, I don't have any reproducer for this issue yet.

Downloadable assets:
disk image: https://storage.googleapis.com/syzbot-assets/267e46ee7273/disk-c16c81c8.raw.xz
vmlinux: https://storage.googleapis.com/syzbot-assets/944e289206cf/vmlinux-c16c81c8.xz
kernel image: https://storage.googleapis.com/syzbot-assets/f8cadf62458e/bzImage-c16c81c8.xz

IMPORTANT: if you fix the issue, please add the following tag to the commit:
Reported-by: [email protected]

ext4 filesystem being mounted at /440/bus supports timestamps until 2038-01-19 (0x7fffffff)
======================================================
WARNING: possible circular locking dependency detected
5.15.178-syzkaller #0 Not tainted
------------------------------------------------------
syz.2.1926/10520 is trying to acquire lock:
ffff88807476f020 (&ei->i_data_sem/1){+.+.}-{3:3}, at: ext4_move_extents+0x3a1/0xe50 fs/ext4/move_extent.c:609

but task is already holding lock:
ffff88807476e628 (&ei->i_data_sem/2){++++}-{3:3}, at: ext4_double_down_write_data_sem+0x28/0x40

which lock already depends on the new lock.


the existing dependency chain (in reverse order) is:

-> #3 (&ei->i_data_sem/2){++++}-{3:3}:
lock_acquire+0x1db/0x4f0 kernel/locking/lockdep.c:5623
down_write+0x38/0x60 kernel/locking/rwsem.c:1551
ext4_map_blocks+0x9a2/0x1c70 fs/ext4/inode.c:665
ext4_getblk+0x19f/0x710 fs/ext4/inode.c:869
ext4_bread+0x2a/0x170 fs/ext4/inode.c:922
ext4_quota_write+0x21e/0x580 fs/ext4/super.c:6567
write_blk fs/quota/quota_tree.c:64 [inline]
find_free_dqentry fs/quota/quota_tree.c:307 [inline]
do_insert_tree+0xf5a/0x1c20 fs/quota/quota_tree.c:364
do_insert_tree+0x6d0/0x1c20 fs/quota/quota_tree.c:366
do_insert_tree+0x6d0/0x1c20 fs/quota/quota_tree.c:366
do_insert_tree+0x6d0/0x1c20 fs/quota/quota_tree.c:366
dq_insert_tree fs/quota/quota_tree.c:392 [inline]
qtree_write_dquot+0x3b9/0x530 fs/quota/quota_tree.c:411
v2_write_dquot+0x11c/0x190 fs/quota/quota_v2.c:358
dquot_acquire+0x34d/0x680 fs/quota/dquot.c:472
ext4_acquire_dquot+0x2eb/0x4a0 fs/ext4/super.c:6193
dqget+0x762/0xe90 fs/quota/dquot.c:988
__dquot_initialize+0x2d9/0xea0 fs/quota/dquot.c:1517
ext4_mknod+0xb6/0x560 fs/ext4/namei.c:2911
vfs_mknod+0x444/0x4d0 fs/namei.c:3944
do_mknodat+0x392/0x690
__do_sys_mknodat fs/namei.c:4022 [inline]
__se_sys_mknodat fs/namei.c:4019 [inline]
__x64_sys_mknodat+0xa5/0xc0 fs/namei.c:4019
do_syscall_x64 arch/x86/entry/common.c:50 [inline]
do_syscall_64+0x3b/0xb0 arch/x86/entry/common.c:80
entry_SYSCALL_64_after_hwframe+0x66/0xd0

-> #2 (&s->s_dquot.dqio_sem){++++}-{3:3}:
lock_acquire+0x1db/0x4f0 kernel/locking/lockdep.c:5623
down_read+0x45/0x2e0 kernel/locking/rwsem.c:1498
v2_read_dquot+0x4a/0x100 fs/quota/quota_v2.c:332
dquot_acquire+0x188/0x680 fs/quota/dquot.c:463
ext4_acquire_dquot+0x2eb/0x4a0 fs/ext4/super.c:6193
dqget+0x762/0xe90 fs/quota/dquot.c:988
__dquot_initialize+0x2d9/0xea0 fs/quota/dquot.c:1517
ext4_create+0xb1/0x550 fs/ext4/namei.c:2876
lookup_open fs/namei.c:3462 [inline]
open_last_lookups fs/namei.c:3532 [inline]
path_openat+0x130a/0x2f20 fs/namei.c:3739
do_filp_open+0x21c/0x460 fs/namei.c:3769
do_sys_openat2+0x13b/0x4f0 fs/open.c:1253
do_sys_open fs/open.c:1269 [inline]
__do_sys_openat fs/open.c:1285 [inline]
__se_sys_openat fs/open.c:1280 [inline]
__x64_sys_openat+0x243/0x290 fs/open.c:1280
do_syscall_x64 arch/x86/entry/common.c:50 [inline]
do_syscall_64+0x3b/0xb0 arch/x86/entry/common.c:80
entry_SYSCALL_64_after_hwframe+0x66/0xd0

-> #1 (&dquot->dq_lock){+.+.}-{3:3}:
lock_acquire+0x1db/0x4f0 kernel/locking/lockdep.c:5623
__mutex_lock_common+0x1da/0x25a0 kernel/locking/mutex.c:596
__mutex_lock kernel/locking/mutex.c:729 [inline]
mutex_lock_nested+0x17/0x20 kernel/locking/mutex.c:743
dquot_commit+0x57/0x510 fs/quota/dquot.c:507
ext4_write_dquot+0x1fd/0x360 fs/ext4/super.c:6173
mark_dquot_dirty fs/quota/dquot.c:372 [inline]
mark_all_dquot_dirty+0xf7/0x400 fs/quota/dquot.c:412
__dquot_alloc_space+0xdd8/0x1090 fs/quota/dquot.c:1752
dquot_alloc_space_nodirty include/linux/quotaops.h:297 [inline]
dquot_alloc_space include/linux/quotaops.h:310 [inline]
swap_inode_boot_loader fs/ext4/ioctl.c:243 [inline]
__ext4_ioctl fs/ext4/ioctl.c:1056 [inline]
ext4_ioctl+0x4d2f/0x5b80 fs/ext4/ioctl.c:1276
vfs_ioctl fs/ioctl.c:51 [inline]
__do_sys_ioctl fs/ioctl.c:874 [inline]
__se_sys_ioctl+0xf1/0x160 fs/ioctl.c:860
do_syscall_x64 arch/x86/entry/common.c:50 [inline]
do_syscall_64+0x3b/0xb0 arch/x86/entry/common.c:80
entry_SYSCALL_64_after_hwframe+0x66/0xd0

-> #0 (&ei->i_data_sem/1){+.+.}-{3:3}:
check_prev_add kernel/locking/lockdep.c:3053 [inline]
check_prevs_add kernel/locking/lockdep.c:3172 [inline]
validate_chain+0x1649/0x5930 kernel/locking/lockdep.c:3788
__lock_acquire+0x1295/0x1ff0 kernel/locking/lockdep.c:5012
lock_acquire+0x1db/0x4f0 kernel/locking/lockdep.c:5623
down_write_nested+0x3b/0x60 kernel/locking/rwsem.c:1667
ext4_move_extents+0x3a1/0xe50 fs/ext4/move_extent.c:609
__ext4_ioctl fs/ext4/ioctl.c:990 [inline]
ext4_ioctl+0x2fcb/0x5b80 fs/ext4/ioctl.c:1276
vfs_ioctl fs/ioctl.c:51 [inline]
__do_sys_ioctl fs/ioctl.c:874 [inline]
__se_sys_ioctl+0xf1/0x160 fs/ioctl.c:860
do_syscall_x64 arch/x86/entry/common.c:50 [inline]
do_syscall_64+0x3b/0xb0 arch/x86/entry/common.c:80
entry_SYSCALL_64_after_hwframe+0x66/0xd0

other info that might help us debug this:

Chain exists of:
&ei->i_data_sem/1 --> &s->s_dquot.dqio_sem --> &ei->i_data_sem/2

Possible unsafe locking scenario:

CPU0 CPU1
---- ----
lock(&ei->i_data_sem/2);
lock(&s->s_dquot.dqio_sem);
lock(&ei->i_data_sem/2);
lock(&ei->i_data_sem/1);

*** DEADLOCK ***

4 locks held by syz.2.1926/10520:
#0: ffff88805a7c4460 (sb_writers#5){.+.+}-{0:0}, at: mnt_want_write_file+0x5a/0x1f0 fs/namespace.c:421
#1: ffff88807476e7a0 (&sb->s_type->i_mutex_key#9){++++}-{3:3}, at: inode_lock include/linux/fs.h:789 [inline]
#1: ffff88807476e7a0 (&sb->s_type->i_mutex_key#9){++++}-{3:3}, at: lock_two_nondirectories+0xde/0x130 fs/inode.c:1122
#2: ffff88807476f198 (&sb->s_type->i_mutex_key#9/4){+.+.}-{3:3}, at: ext4_move_extents+0x386/0xe50 fs/ext4/move_extent.c:602
#3: ffff88807476e628 (&ei->i_data_sem/2){++++}-{3:3}, at: ext4_double_down_write_data_sem+0x28/0x40

stack backtrace:
CPU: 1 PID: 10520 Comm: syz.2.1926 Not tainted 5.15.178-syzkaller #0
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 12/27/2024
Call Trace:
<TASK>
__dump_stack lib/dump_stack.c:88 [inline]
dump_stack_lvl+0x1e3/0x2d0 lib/dump_stack.c:106
check_noncircular+0x2f8/0x3b0 kernel/locking/lockdep.c:2133
check_prev_add kernel/locking/lockdep.c:3053 [inline]
check_prevs_add kernel/locking/lockdep.c:3172 [inline]
validate_chain+0x1649/0x5930 kernel/locking/lockdep.c:3788
__lock_acquire+0x1295/0x1ff0 kernel/locking/lockdep.c:5012
lock_acquire+0x1db/0x4f0 kernel/locking/lockdep.c:5623
down_write_nested+0x3b/0x60 kernel/locking/rwsem.c:1667
ext4_move_extents+0x3a1/0xe50 fs/ext4/move_extent.c:609
__ext4_ioctl fs/ext4/ioctl.c:990 [inline]
ext4_ioctl+0x2fcb/0x5b80 fs/ext4/ioctl.c:1276
vfs_ioctl fs/ioctl.c:51 [inline]
__do_sys_ioctl fs/ioctl.c:874 [inline]
__se_sys_ioctl+0xf1/0x160 fs/ioctl.c:860
do_syscall_x64 arch/x86/entry/common.c:50 [inline]
do_syscall_64+0x3b/0xb0 arch/x86/entry/common.c:80
entry_SYSCALL_64_after_hwframe+0x66/0xd0
RIP: 0033:0x7fbb57d9ada9
Code: ff ff c3 66 2e 0f 1f 84 00 00 00 00 00 0f 1f 40 00 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 c7 c1 a8 ff ff ff f7 d8 64 89 01 48
RSP: 002b:00007fbb55c04038 EFLAGS: 00000246 ORIG_RAX: 0000000000000010
RAX: ffffffffffffffda RBX: 00007fbb57fb3fa0 RCX: 00007fbb57d9ada9
RDX: 0000000020000240 RSI: 00000000c028660f RDI: 0000000000000005
RBP: 00007fbb57e1c2a0 R08: 0000000000000000 R09: 0000000000000000
R10: 0000000000000000 R11: 0000000000000246 R12: 0000000000000000
R13: 0000000000000000 R14: 00007fbb57fb3fa0 R15: 00007ffeed2640e8
</TASK>


---
This report is generated by a bot. It may contain errors.
See https://goo.gl/tpsmEJ for more information about syzbot.
syzbot engineers can be reached at [email protected].

syzbot will keep track of this issue. See:
https://goo.gl/tpsmEJ#status for how to communicate with syzbot.

If the report is already addressed, let syzbot know by replying with:
#syz fix: exact-commit-title

If you want to overwrite report's subsystems, reply with:
#syz set subsystems: new-subsystem
(See the list of subsystem names on the web dashboard)

If the report is a duplicate of another one, reply with:
#syz dup: exact-subject-of-another-report

If you want to undo deduplication, reply with:
#syz undup