[v5.15] possible deadlock in ocfs2_setattr

Hello,

syzbot found the following issue on:

HEAD commit: 3a5928702e71 Linux 5.15.167
git tree: linux-5.15.y
console output: https://syzkaller.appspot.com/x/log.txt?x=141dee9f980000
kernel config: https://syzkaller.appspot.com/x/.config?x=171882977b524c53
dashboard link: https://syzkaller.appspot.com/bug?extid=50d7961da48e2cadc59a
compiler: Debian clang version 15.0.6, GNU ld (GNU Binutils for Debian) 2.40
userspace arch: arm64

Unfortunately, I don't have any reproducer for this issue yet.

Downloadable assets:
disk image: https://storage.googleapis.com/syzbot-assets/22ee27cb312d/disk-3a592870.raw.xz
vmlinux: https://storage.googleapis.com/syzbot-assets/90bf6a3e3d20/vmlinux-3a592870.xz
kernel image: https://storage.googleapis.com/syzbot-assets/096dd2c73ac3/Image-3a592870.gz.xz

IMPORTANT: if you fix the issue, please add the following tag to the commit:
Reported-by: [email protected]

======================================================
WARNING: possible circular locking dependency detected
5.15.167-syzkaller #0 Not tainted
------------------------------------------------------
syz.0.119/4823 is trying to acquire lock:
ffff0000d976e650 (sb_internal#5){.+.+}-{0:0}, at: ocfs2_setattr+0x94c/0x191c fs/ocfs2/file.c:1263

but task is already holding lock:
ffff0000e00f5be0 (&oi->ip_alloc_sem){+.+.}-{3:3}, at: ocfs2_setattr+0x940/0x191c fs/ocfs2/file.c:1262

which lock already depends on the new lock.


the existing dependency chain (in reverse order) is:

-> #4 (&oi->ip_alloc_sem){+.+.}-{3:3}:
down_write+0xbc/0x12c kernel/locking/rwsem.c:1551
ocfs2_try_remove_refcount_tree+0xb4/0x2f0 fs/ocfs2/refcounttree.c:931
ocfs2_xattr_set+0x7b8/0x1478 fs/ocfs2/xattr.c:3665
ocfs2_set_acl+0x410/0x4b4 fs/ocfs2/acl.c:254
ocfs2_iop_set_acl+0x214/0x358 fs/ocfs2/acl.c:285
set_posix_acl fs/posix_acl.c:947 [inline]
posix_acl_xattr_set+0x2cc/0x378 fs/posix_acl.c:966
__vfs_removexattr+0x370/0x38c fs/xattr.c:470
__vfs_removexattr_locked+0x1d8/0x380 fs/xattr.c:505
vfs_removexattr+0xe0/0x23c fs/xattr.c:527
ovl_workdir_create+0x360/0x624 fs/overlayfs/super.c:818
ovl_make_workdir fs/overlayfs/super.c:1374 [inline]
ovl_get_workdir+0x344/0x1110 fs/overlayfs/super.c:1524
ovl_fill_super+0x15b4/0x2254 fs/overlayfs/super.c:2080
mount_nodev+0x68/0x104 fs/super.c:1444
ovl_mount+0x3c/0x50 fs/overlayfs/super.c:2171
legacy_get_tree+0xd4/0x16c fs/fs_context.c:611
vfs_get_tree+0x90/0x274 fs/super.c:1528
do_new_mount+0x278/0x8fc fs/namespace.c:3005
path_mount+0x594/0x101c fs/namespace.c:3335
do_mount fs/namespace.c:3348 [inline]
__do_sys_mount fs/namespace.c:3556 [inline]
__se_sys_mount fs/namespace.c:3533 [inline]
__arm64_sys_mount+0x510/0x5e0 fs/namespace.c:3533
__invoke_syscall arch/arm64/kernel/syscall.c:38 [inline]
invoke_syscall+0x98/0x2b8 arch/arm64/kernel/syscall.c:52
el0_svc_common+0x138/0x258 arch/arm64/kernel/syscall.c:142
do_el0_svc+0x58/0x14c arch/arm64/kernel/syscall.c:181
el0_svc+0x7c/0x1f0 arch/arm64/kernel/entry-common.c:608
el0t_64_sync_handler+0x84/0xe4 arch/arm64/kernel/entry-common.c:626
el0t_64_sync+0x1a0/0x1a4 arch/arm64/kernel/entry.S:584

-> #3 (&oi->ip_xattr_sem){++++}-{3:3}:
down_read+0xc0/0x398 kernel/locking/rwsem.c:1498
ocfs2_init_acl+0x2d0/0x778 fs/ocfs2/acl.c:365
ocfs2_mknod+0x1558/0x24f8 fs/ocfs2/namei.c:408
ocfs2_mkdir+0x184/0x4c8 fs/ocfs2/namei.c:655
vfs_mkdir+0x334/0x4e4 fs/namei.c:4065
do_mkdirat+0x20c/0x610 fs/namei.c:4090
__do_sys_mkdirat fs/namei.c:4105 [inline]
__se_sys_mkdirat fs/namei.c:4103 [inline]
__arm64_sys_mkdirat+0x90/0xa8 fs/namei.c:4103
__invoke_syscall arch/arm64/kernel/syscall.c:38 [inline]
invoke_syscall+0x98/0x2b8 arch/arm64/kernel/syscall.c:52
el0_svc_common+0x138/0x258 arch/arm64/kernel/syscall.c:142
do_el0_svc+0x58/0x14c arch/arm64/kernel/syscall.c:181
el0_svc+0x7c/0x1f0 arch/arm64/kernel/entry-common.c:608
el0t_64_sync_handler+0x84/0xe4 arch/arm64/kernel/entry-common.c:626
el0t_64_sync+0x1a0/0x1a4 arch/arm64/kernel/entry.S:584

-> #2 (jbd2_handle){++++}-{0:0}:
start_this_handle+0xfc0/0x12a4 fs/jbd2/transaction.c:464
jbd2__journal_start+0x29c/0x7b4 fs/jbd2/transaction.c:521
jbd2_journal_start+0x3c/0x4c fs/jbd2/transaction.c:560
ocfs2_start_trans+0x468/0x804 fs/ocfs2/journal.c:354
ocfs2_mknod+0xe68/0x24f8 fs/ocfs2/namei.c:359
ocfs2_mkdir+0x184/0x4c8 fs/ocfs2/namei.c:655
vfs_mkdir+0x334/0x4e4 fs/namei.c:4065
do_mkdirat+0x20c/0x610 fs/namei.c:4090
__do_sys_mkdirat fs/namei.c:4105 [inline]
__se_sys_mkdirat fs/namei.c:4103 [inline]
__arm64_sys_mkdirat+0x90/0xa8 fs/namei.c:4103
__invoke_syscall arch/arm64/kernel/syscall.c:38 [inline]
invoke_syscall+0x98/0x2b8 arch/arm64/kernel/syscall.c:52
el0_svc_common+0x138/0x258 arch/arm64/kernel/syscall.c:142
do_el0_svc+0x58/0x14c arch/arm64/kernel/syscall.c:181
el0_svc+0x7c/0x1f0 arch/arm64/kernel/entry-common.c:608
el0t_64_sync_handler+0x84/0xe4 arch/arm64/kernel/entry-common.c:626
el0t_64_sync+0x1a0/0x1a4 arch/arm64/kernel/entry.S:584

-> #1 (&journal->j_trans_barrier){.+.+}-{3:3}:
down_read+0xc0/0x398 kernel/locking/rwsem.c:1498
ocfs2_start_trans+0x45c/0x804 fs/ocfs2/journal.c:352
ocfs2_mknod+0xe68/0x24f8 fs/ocfs2/namei.c:359
ocfs2_mkdir+0x184/0x4c8 fs/ocfs2/namei.c:655
vfs_mkdir+0x334/0x4e4 fs/namei.c:4065
do_mkdirat+0x20c/0x610 fs/namei.c:4090
__do_sys_mkdirat fs/namei.c:4105 [inline]
__se_sys_mkdirat fs/namei.c:4103 [inline]
__arm64_sys_mkdirat+0x90/0xa8 fs/namei.c:4103
__invoke_syscall arch/arm64/kernel/syscall.c:38 [inline]
invoke_syscall+0x98/0x2b8 arch/arm64/kernel/syscall.c:52
el0_svc_common+0x138/0x258 arch/arm64/kernel/syscall.c:142
do_el0_svc+0x58/0x14c arch/arm64/kernel/syscall.c:181
el0_svc+0x7c/0x1f0 arch/arm64/kernel/entry-common.c:608
el0t_64_sync_handler+0x84/0xe4 arch/arm64/kernel/entry-common.c:626
el0t_64_sync+0x1a0/0x1a4 arch/arm64/kernel/entry.S:584

-> #0 (sb_internal#5){.+.+}-{0:0}:
check_prev_add kernel/locking/lockdep.c:3053 [inline]
check_prevs_add kernel/locking/lockdep.c:3172 [inline]
validate_chain kernel/locking/lockdep.c:3788 [inline]
__lock_acquire+0x32d4/0x7638 kernel/locking/lockdep.c:5012
lock_acquire+0x240/0x77c kernel/locking/lockdep.c:5623
percpu_down_read include/linux/percpu-rwsem.h:51 [inline]
__sb_start_write include/linux/fs.h:1811 [inline]
sb_start_intwrite include/linux/fs.h:1928 [inline]
ocfs2_start_trans+0x2dc/0x804 fs/ocfs2/journal.c:350
ocfs2_setattr+0x94c/0x191c fs/ocfs2/file.c:1263
notify_change+0xa34/0xcf8 fs/attr.c:505
ovl_workdir_create+0x498/0x624 fs/overlayfs/super.c:830
ovl_make_workdir fs/overlayfs/super.c:1374 [inline]
ovl_get_workdir+0x344/0x1110 fs/overlayfs/super.c:1524
ovl_fill_super+0x15b4/0x2254 fs/overlayfs/super.c:2080
mount_nodev+0x68/0x104 fs/super.c:1444
ovl_mount+0x3c/0x50 fs/overlayfs/super.c:2171
legacy_get_tree+0xd4/0x16c fs/fs_context.c:611
vfs_get_tree+0x90/0x274 fs/super.c:1528
do_new_mount+0x278/0x8fc fs/namespace.c:3005
path_mount+0x594/0x101c fs/namespace.c:3335
do_mount fs/namespace.c:3348 [inline]
__do_sys_mount fs/namespace.c:3556 [inline]
__se_sys_mount fs/namespace.c:3533 [inline]
__arm64_sys_mount+0x510/0x5e0 fs/namespace.c:3533
__invoke_syscall arch/arm64/kernel/syscall.c:38 [inline]
invoke_syscall+0x98/0x2b8 arch/arm64/kernel/syscall.c:52
el0_svc_common+0x138/0x258 arch/arm64/kernel/syscall.c:142
do_el0_svc+0x58/0x14c arch/arm64/kernel/syscall.c:181
el0_svc+0x7c/0x1f0 arch/arm64/kernel/entry-common.c:608
el0t_64_sync_handler+0x84/0xe4 arch/arm64/kernel/entry-common.c:626
el0t_64_sync+0x1a0/0x1a4 arch/arm64/kernel/entry.S:584

other info that might help us debug this:

Chain exists of:
sb_internal#5 --> &oi->ip_xattr_sem --> &oi->ip_alloc_sem

Possible unsafe locking scenario:

CPU0 CPU1
---- ----
lock(&oi->ip_alloc_sem);
lock(&oi->ip_xattr_sem);
lock(&oi->ip_alloc_sem);
lock(sb_internal#5);

*** DEADLOCK ***

5 locks held by syz.0.119/4823:
#0: ffff0000cbdfc0e0 (&type->s_umount_key#49/1){+.+.}-{3:3}, at: alloc_super+0x1b8/0x844 fs/super.c:229
#1: ffff0000d976e460 (sb_writers#26){.+.+}-{0:0}, at: mnt_want_write+0x44/0x9c fs/namespace.c:377
#2: ffff0000e00f5108 (&sb->s_type->i_mutex_key#33/1){+.+.}-{3:3}, at: inode_lock_nested include/linux/fs.h:824 [inline]
#2: ffff0000e00f5108 (&sb->s_type->i_mutex_key#33/1){+.+.}-{3:3}, at: ovl_workdir_create+0x130/0x624 fs/overlayfs/super.c:768
#3: ffff0000e00f5f48 (&sb->s_type->i_mutex_key#35){+.+.}-{3:3}, at: inode_lock include/linux/fs.h:789 [inline]
#3: ffff0000e00f5f48 (&sb->s_type->i_mutex_key#35){+.+.}-{3:3}, at: ovl_workdir_create+0x46c/0x624 fs/overlayfs/super.c:829
#4: ffff0000e00f5be0 (&oi->ip_alloc_sem){+.+.}-{3:3}, at: ocfs2_setattr+0x940/0x191c fs/ocfs2/file.c:1262

stack backtrace:
CPU: 0 PID: 4823 Comm: syz.0.119 Not tainted 5.15.167-syzkaller #0
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 08/06/2024
Call trace:
dump_backtrace+0x0/0x530 arch/arm64/kernel/stacktrace.c:152
show_stack+0x2c/0x3c arch/arm64/kernel/stacktrace.c:216
__dump_stack lib/dump_stack.c:88 [inline]
dump_stack_lvl+0x108/0x170 lib/dump_stack.c:106
dump_stack+0x1c/0x58 lib/dump_stack.c:113
print_circular_bug+0x150/0x1b8 kernel/locking/lockdep.c:2011
check_noncircular+0x2cc/0x378 kernel/locking/lockdep.c:2133
check_prev_add kernel/locking/lockdep.c:3053 [inline]
check_prevs_add kernel/locking/lockdep.c:3172 [inline]
validate_chain kernel/locking/lockdep.c:3788 [inline]
__lock_acquire+0x32d4/0x7638 kernel/locking/lockdep.c:5012
lock_acquire+0x240/0x77c kernel/locking/lockdep.c:5623
percpu_down_read include/linux/percpu-rwsem.h:51 [inline]
__sb_start_write include/linux/fs.h:1811 [inline]
sb_start_intwrite include/linux/fs.h:1928 [inline]
ocfs2_start_trans+0x2dc/0x804 fs/ocfs2/journal.c:350
ocfs2_setattr+0x94c/0x191c fs/ocfs2/file.c:1263
notify_change+0xa34/0xcf8 fs/attr.c:505
ovl_workdir_create+0x498/0x624 fs/overlayfs/super.c:830
ovl_make_workdir fs/overlayfs/super.c:1374 [inline]
ovl_get_workdir+0x344/0x1110 fs/overlayfs/super.c:1524
ovl_fill_super+0x15b4/0x2254 fs/overlayfs/super.c:2080
mount_nodev+0x68/0x104 fs/super.c:1444
ovl_mount+0x3c/0x50 fs/overlayfs/super.c:2171
legacy_get_tree+0xd4/0x16c fs/fs_context.c:611
vfs_get_tree+0x90/0x274 fs/super.c:1528
do_new_mount+0x278/0x8fc fs/namespace.c:3005
path_mount+0x594/0x101c fs/namespace.c:3335
do_mount fs/namespace.c:3348 [inline]
__do_sys_mount fs/namespace.c:3556 [inline]
__se_sys_mount fs/namespace.c:3533 [inline]
__arm64_sys_mount+0x510/0x5e0 fs/namespace.c:3533
__invoke_syscall arch/arm64/kernel/syscall.c:38 [inline]
invoke_syscall+0x98/0x2b8 arch/arm64/kernel/syscall.c:52
el0_svc_common+0x138/0x258 arch/arm64/kernel/syscall.c:142
do_el0_svc+0x58/0x14c arch/arm64/kernel/syscall.c:181
el0_svc+0x7c/0x1f0 arch/arm64/kernel/entry-common.c:608
el0t_64_sync_handler+0x84/0xe4 arch/arm64/kernel/entry-common.c:626
el0t_64_sync+0x1a0/0x1a4 arch/arm64/kernel/entry.S:584
overlayfs: upper fs does not support tmpfile.
overlayfs: upper fs does not support RENAME_WHITEOUT.
overlayfs: upper fs missing required features.


---
This report is generated by a bot. It may contain errors.
See https://goo.gl/tpsmEJ for more information about syzbot.
syzbot engineers can be reached at [email protected].

syzbot will keep track of this issue. See:
https://goo.gl/tpsmEJ#status for how to communicate with syzbot.

If the report is already addressed, let syzbot know by replying with:
#syz fix: exact-commit-title

If you want to overwrite report's subsystems, reply with:
#syz set subsystems: new-subsystem
(See the list of subsystem names on the web dashboard)

If the report is a duplicate of another one, reply with:
#syz dup: exact-subject-of-another-report

If you want to undo deduplication, reply with:
#syz undup

syzbot has found a reproducer for the following issue on:
console output: https://syzkaller.appspot.com/x/log.txt?x=1256f607980000
syz repro: https://syzkaller.appspot.com/x/repro.syz?x=131bee9f980000
C reproducer: https://syzkaller.appspot.com/x/repro.c?x=16e12ca9980000
mounted in repro: https://storage.googleapis.com/syzbot-assets/9a56921cc7eb/mount_0.gz
option from the mount to silence this warning.
=======================================================
ocfs2: Mounting device (7,0) on (node local, slot 0) with ordered data mode.
syz-executor319/4015 is trying to acquire lock:
ffff0000cbf46650 (sb_internal#2){.+.+}-{0:0}, at: ocfs2_setattr+0x94c/0x191c fs/ocfs2/file.c:1263
ffff0000e20e22e0 (&oi->ip_alloc_sem){+.+.}-{3:3}, at: ocfs2_setattr+0x940/0x191c fs/ocfs2/file.c:1262
-> #0 (sb_internal#2){.+.+}-{0:0}:
sb_internal#2 --> &oi->ip_xattr_sem --> &oi->ip_alloc_sem
lock(sb_internal#2);

*** DEADLOCK ***

5 locks held by syz-executor319/4015:
#0: ffff0000dab2c0e0 (&type->s_umount_key#41/1){+.+.}-{3:3}, at: alloc_super+0x1b8/0x844 fs/super.c:229
#1: ffff0000cbf46460 (sb_writers#8){.+.+}-{0:0}, at: mnt_want_write+0x44/0x9c fs/namespace.c:377
#2: ffff0000e20e1808 (&sb->s_type->i_mutex_key#17/1){+.+.}-{3:3}, at: inode_lock_nested include/linux/fs.h:824 [inline]
#2: ffff0000e20e1808 (&sb->s_type->i_mutex_key#17/1){+.+.}-{3:3}, at: ovl_workdir_create+0x130/0x624 fs/overlayfs/super.c:768
#3: ffff0000e20e2648 (&sb->s_type->i_mutex_key#19){+.+.}-{3:3}, at: inode_lock include/linux/fs.h:789 [inline]
#3: ffff0000e20e2648 (&sb->s_type->i_mutex_key#19){+.+.}-{3:3}, at: ovl_workdir_create+0x46c/0x624 fs/overlayfs/super.c:829
#4: ffff0000e20e22e0 (&oi->ip_alloc_sem){+.+.}-{3:3}, at: ocfs2_setattr+0x940/0x191c fs/ocfs2/file.c:1262

stack backtrace:
CPU: 1 PID: 4015 Comm: syz-executor319 Not tainted 5.15.167-syzkaller #0
If you want syzbot to run the reproducer, reply with:
#syz test: git://repo/address.git branch-or-commit-hash
If you attach or paste a git patch, syzbot will apply it before testing.

Hello,

syzbot found the following issue on:

HEAD commit: e526b12bf916 Linux 6.1.111
git tree: linux-6.1.y
console output: https://syzkaller.appspot.com/x/log.txt?x=122e3880580000
kernel config: https://syzkaller.appspot.com/x/.config?x=7418080a6f941760
dashboard link: https://syzkaller.appspot.com/bug?extid=b7d1ddca885cd6bdb6ce
Downloadable assets:
disk image: https://storage.googleapis.com/syzbot-assets/1729a6745b21/disk-e526b12b.raw.xz
vmlinux: https://storage.googleapis.com/syzbot-assets/f358663fa696/vmlinux-e526b12b.xz
kernel image: https://storage.googleapis.com/syzbot-assets/9b39a7b8f250/Image-e526b12b.gz.xz
Reported-by: [email protected]
6.1.111-syzkaller #0 Not tainted
------------------------------------------------------
syz.4.42/4545 is trying to acquire lock:
ffff0000f776a650 (sb_internal#2){.+.+}-{0:0}, at: ocfs2_setattr+0xb14/0x1b3c fs/ocfs2/file.c:1260
ffff0000e36822e0 (&oi->ip_alloc_sem){+.+.}-{3:3}, at: ocfs2_setattr+0xb08/0x1b3c fs/ocfs2/file.c:1259
down_write+0x5c/0x88 kernel/locking/rwsem.c:1573
set_posix_acl fs/posix_acl.c:1160 [inline]
posix_acl_xattr_set+0x2f8/0x398 fs/posix_acl.c:1189
__vfs_removexattr+0x370/0x38c fs/xattr.c:479
__vfs_removexattr_locked+0x1d8/0x380 fs/xattr.c:514
vfs_removexattr+0xe0/0x23c fs/xattr.c:536
ovl_do_removexattr fs/overlayfs/overlayfs.h:270 [inline]
ovl_workdir_create+0x400/0x7c8 fs/overlayfs/super.c:821
ovl_make_workdir fs/overlayfs/super.c:1389 [inline]
ovl_get_workdir+0x354/0x13d4 fs/overlayfs/super.c:1539
ovl_fill_super+0x15b4/0x2254 fs/overlayfs/super.c:2095
mount_nodev+0x68/0x104 fs/super.c:1489
ovl_mount+0x3c/0x50 fs/overlayfs/super.c:2186
legacy_get_tree+0xd4/0x16c fs/fs_context.c:632
vfs_get_tree+0x90/0x274 fs/super.c:1573
do_new_mount+0x278/0x8fc fs/namespace.c:3051
path_mount+0x590/0xe5c fs/namespace.c:3381
do_mount fs/namespace.c:3394 [inline]
__do_sys_mount fs/namespace.c:3602 [inline]
__se_sys_mount fs/namespace.c:3579 [inline]
__arm64_sys_mount+0x45c/0x594 fs/namespace.c:3579
__invoke_syscall arch/arm64/kernel/syscall.c:38 [inline]
invoke_syscall+0x98/0x2c0 arch/arm64/kernel/syscall.c:52
el0_svc_common+0x138/0x258 arch/arm64/kernel/syscall.c:140
do_el0_svc+0x64/0x218 arch/arm64/kernel/syscall.c:204
el0_svc+0x58/0x168 arch/arm64/kernel/entry-common.c:637
el0t_64_sync_handler+0x84/0xf0 arch/arm64/kernel/entry-common.c:655
el0t_64_sync+0x18c/0x190 arch/arm64/kernel/entry.S:585
down_read+0x64/0x308 kernel/locking/rwsem.c:1520
ocfs2_init_acl+0x2c8/0x764 fs/ocfs2/acl.c:365
ocfs2_mknod+0x1574/0x2560 fs/ocfs2/namei.c:408
ocfs2_mkdir+0x1a8/0x560 fs/ocfs2/namei.c:655
vfs_mkdir+0x334/0x4e4 fs/namei.c:4108
do_mkdirat+0x220/0x510 fs/namei.c:4133
__do_sys_mkdirat fs/namei.c:4148 [inline]
__se_sys_mkdirat fs/namei.c:4146 [inline]
__arm64_sys_mkdirat+0x90/0xa8 fs/namei.c:4146
__invoke_syscall arch/arm64/kernel/syscall.c:38 [inline]
invoke_syscall+0x98/0x2c0 arch/arm64/kernel/syscall.c:52
el0_svc_common+0x138/0x258 arch/arm64/kernel/syscall.c:140
do_el0_svc+0x64/0x218 arch/arm64/kernel/syscall.c:204
el0_svc+0x58/0x168 arch/arm64/kernel/entry-common.c:637
el0t_64_sync_handler+0x84/0xf0 arch/arm64/kernel/entry-common.c:655
el0t_64_sync+0x18c/0x190 arch/arm64/kernel/entry.S:585
start_this_handle+0x1140/0x13ac fs/jbd2/transaction.c:463
jbd2__journal_start+0x298/0x544 fs/jbd2/transaction.c:520
jbd2_journal_start+0x3c/0x4c fs/jbd2/transaction.c:559
ocfs2_start_trans+0x3e8/0x73c fs/ocfs2/journal.c:354
ocfs2_shutdown_local_alloc+0x1d8/0x8d8 fs/ocfs2/localalloc.c:416
ocfs2_dismount_volume+0x1fc/0x99c fs/ocfs2/super.c:1879
ocfs2_put_super+0x110/0x3e8 fs/ocfs2/super.c:1609
generic_shutdown_super+0x130/0x328 fs/super.c:501
kill_block_super+0x70/0xdc fs/super.c:1470
deactivate_locked_super+0xac/0x124 fs/super.c:332
deactivate_super+0xf0/0x110 fs/super.c:363
cleanup_mnt+0x394/0x41c fs/namespace.c:1186
__cleanup_mnt+0x20/0x30 fs/namespace.c:1193
task_work_run+0x240/0x2f0 kernel/task_work.c:203
resume_user_mode_work include/linux/resume_user_mode.h:49 [inline]
do_notify_resume+0x2148/0x3474 arch/arm64/kernel/signal.c:1132
prepare_exit_to_user_mode arch/arm64/kernel/entry-common.c:137 [inline]
exit_to_user_mode arch/arm64/kernel/entry-common.c:142 [inline]
el0_svc+0x9c/0x168 arch/arm64/kernel/entry-common.c:638
el0t_64_sync_handler+0x84/0xf0 arch/arm64/kernel/entry-common.c:655
el0t_64_sync+0x18c/0x190 arch/arm64/kernel/entry.S:585
down_read+0x64/0x308 kernel/locking/rwsem.c:1520
ocfs2_start_trans+0x3dc/0x73c fs/ocfs2/journal.c:352
ocfs2_shutdown_local_alloc+0x1d8/0x8d8 fs/ocfs2/localalloc.c:416
ocfs2_dismount_volume+0x1fc/0x99c fs/ocfs2/super.c:1879
ocfs2_put_super+0x110/0x3e8 fs/ocfs2/super.c:1609
generic_shutdown_super+0x130/0x328 fs/super.c:501
kill_block_super+0x70/0xdc fs/super.c:1470
deactivate_locked_super+0xac/0x124 fs/super.c:332
deactivate_super+0xf0/0x110 fs/super.c:363
cleanup_mnt+0x394/0x41c fs/namespace.c:1186
__cleanup_mnt+0x20/0x30 fs/namespace.c:1193
task_work_run+0x240/0x2f0 kernel/task_work.c:203
resume_user_mode_work include/linux/resume_user_mode.h:49 [inline]
do_notify_resume+0x2148/0x3474 arch/arm64/kernel/signal.c:1132
prepare_exit_to_user_mode arch/arm64/kernel/entry-common.c:137 [inline]
exit_to_user_mode arch/arm64/kernel/entry-common.c:142 [inline]
el0_svc+0x9c/0x168 arch/arm64/kernel/entry-common.c:638
el0t_64_sync_handler+0x84/0xf0 arch/arm64/kernel/entry-common.c:655
el0t_64_sync+0x18c/0x190 arch/arm64/kernel/entry.S:585
check_prev_add kernel/locking/lockdep.c:3090 [inline]
check_prevs_add kernel/locking/lockdep.c:3209 [inline]
validate_chain kernel/locking/lockdep.c:3825 [inline]
__lock_acquire+0x3338/0x7680 kernel/locking/lockdep.c:5049
lock_acquire+0x26c/0x7cc kernel/locking/lockdep.c:5662
percpu_down_read include/linux/percpu-rwsem.h:51 [inline]
__sb_start_write include/linux/fs.h:1891 [inline]
sb_start_intwrite include/linux/fs.h:2013 [inline]
ocfs2_start_trans+0x260/0x73c fs/ocfs2/journal.c:350
ocfs2_setattr+0xb14/0x1b3c fs/ocfs2/file.c:1260
notify_change+0xb58/0xe1c fs/attr.c:499
ovl_do_notify_change fs/overlayfs/overlayfs.h:142 [inline]
ovl_workdir_create+0x5d0/0x7c8 fs/overlayfs/super.c:833
ovl_make_workdir fs/overlayfs/super.c:1389 [inline]
ovl_get_workdir+0x354/0x13d4 fs/overlayfs/super.c:1539
ovl_fill_super+0x15b4/0x2254 fs/overlayfs/super.c:2095
mount_nodev+0x68/0x104 fs/super.c:1489
ovl_mount+0x3c/0x50 fs/overlayfs/super.c:2186
legacy_get_tree+0xd4/0x16c fs/fs_context.c:632
vfs_get_tree+0x90/0x274 fs/super.c:1573
do_new_mount+0x278/0x8fc fs/namespace.c:3051
path_mount+0x590/0xe5c fs/namespace.c:3381
do_mount fs/namespace.c:3394 [inline]
__do_sys_mount fs/namespace.c:3602 [inline]
__se_sys_mount fs/namespace.c:3579 [inline]
__arm64_sys_mount+0x45c/0x594 fs/namespace.c:3579
__invoke_syscall arch/arm64/kernel/syscall.c:38 [inline]
invoke_syscall+0x98/0x2c0 arch/arm64/kernel/syscall.c:52
el0_svc_common+0x138/0x258 arch/arm64/kernel/syscall.c:140
do_el0_svc+0x64/0x218 arch/arm64/kernel/syscall.c:204
el0_svc+0x58/0x168 arch/arm64/kernel/entry-common.c:637
el0t_64_sync_handler+0x84/0xf0 arch/arm64/kernel/entry-common.c:655
el0t_64_sync+0x18c/0x190 arch/arm64/kernel/entry.S:585
5 locks held by syz.4.42/4545:
#0: ffff0000f3cf00e0 (&type->s_umount_key#48/1){+.+.}-{3:3}, at: alloc_super+0x1b4/0x824 fs/super.c:228
#1: ffff0000f776a460 (sb_writers#19){.+.+}-{0:0}, at: mnt_want_write+0x44/0x9c fs/namespace.c:393
#2: ffff0000e3681808 (&sb->s_type->i_mutex_key#25/1){+.+.}-{3:3}, at: inode_lock_nested include/linux/fs.h:793 [inline]
#2: ffff0000e3681808 (&sb->s_type->i_mutex_key#25/1){+.+.}-{3:3}, at: ovl_workdir_create+0x13c/0x7c8 fs/overlayfs/super.c:771
#3: ffff0000e3682648 (&sb->s_type->i_mutex_key#25){+.+.}-{3:3}, at: inode_lock include/linux/fs.h:758 [inline]
#3: ffff0000e3682648 (&sb->s_type->i_mutex_key#25){+.+.}-{3:3}, at: ovl_workdir_create+0x564/0x7c8 fs/overlayfs/super.c:832
#4: ffff0000e36822e0 (&oi->ip_alloc_sem){+.+.}-{3:3}, at: ocfs2_setattr+0xb08/0x1b3c fs/ocfs2/file.c:1259

stack backtrace:
CPU: 0 PID: 4545 Comm: syz.4.42 Not tainted 6.1.111-syzkaller #0
dump_backtrace+0x1c8/0x1f4 arch/arm64/kernel/stacktrace.c:158
show_stack+0x2c/0x3c arch/arm64/kernel/stacktrace.c:165
print_circular_bug+0x150/0x1b8 kernel/locking/lockdep.c:2048
check_noncircular+0x2cc/0x378 kernel/locking/lockdep.c:2170
check_prev_add kernel/locking/lockdep.c:3090 [inline]
check_prevs_add kernel/locking/lockdep.c:3209 [inline]
validate_chain kernel/locking/lockdep.c:3825 [inline]
__lock_acquire+0x3338/0x7680 kernel/locking/lockdep.c:5049
lock_acquire+0x26c/0x7cc kernel/locking/lockdep.c:5662
percpu_down_read include/linux/percpu-rwsem.h:51 [inline]
__sb_start_write include/linux/fs.h:1891 [inline]
sb_start_intwrite include/linux/fs.h:2013 [inline]
ocfs2_start_trans+0x260/0x73c fs/ocfs2/journal.c:350
ocfs2_setattr+0xb14/0x1b3c fs/ocfs2/file.c:1260
notify_change+0xb58/0xe1c fs/attr.c:499
ovl_do_notify_change fs/overlayfs/overlayfs.h:142 [inline]
ovl_workdir_create+0x5d0/0x7c8 fs/overlayfs/super.c:833
ovl_make_workdir fs/overlayfs/super.c:1389 [inline]
ovl_get_workdir+0x354/0x13d4 fs/overlayfs/super.c:1539
ovl_fill_super+0x15b4/0x2254 fs/overlayfs/super.c:2095
mount_nodev+0x68/0x104 fs/super.c:1489
ovl_mount+0x3c/0x50 fs/overlayfs/super.c:2186
legacy_get_tree+0xd4/0x16c fs/fs_context.c:632
vfs_get_tree+0x90/0x274 fs/super.c:1573
do_new_mount+0x278/0x8fc fs/namespace.c:3051
path_mount+0x590/0xe5c fs/namespace.c:3381
do_mount fs/namespace.c:3394 [inline]
__do_sys_mount fs/namespace.c:3602 [inline]
__se_sys_mount fs/namespace.c:3579 [inline]
__arm64_sys_mount+0x45c/0x594 fs/namespace.c:3579
__invoke_syscall arch/arm64/kernel/syscall.c:38 [inline]
invoke_syscall+0x98/0x2c0 arch/arm64/kernel/syscall.c:52
el0_svc_common+0x138/0x258 arch/arm64/kernel/syscall.c:140
do_el0_svc+0x64/0x218 arch/arm64/kernel/syscall.c:204
el0_svc+0x58/0x168 arch/arm64/kernel/entry-common.c:637
el0t_64_sync_handler+0x84/0xf0 arch/arm64/kernel/entry-common.c:655
el0t_64_sync+0x18c/0x190 arch/arm64/kernel/entry.S:585

syzbot has found a reproducer for the following issue on:

HEAD commit: 7ec6f9fa3d97 Linux 6.1.114
git tree: linux-6.1.y
console output: https://syzkaller.appspot.com/x/log.txt?x=13dafe5f980000
kernel config: https://syzkaller.appspot.com/x/.config?x=c3430b5172170129
syz repro: https://syzkaller.appspot.com/x/repro.syz?x=15e36940580000
C reproducer: https://syzkaller.appspot.com/x/repro.c?x=13e36940580000

Downloadable assets:
disk image: https://storage.googleapis.com/syzbot-assets/85855dd3567d/disk-7ec6f9fa.raw.xz
vmlinux: https://storage.googleapis.com/syzbot-assets/2938cf086485/vmlinux-7ec6f9fa.xz
kernel image: https://storage.googleapis.com/syzbot-assets/708aae50ad2d/bzImage-7ec6f9fa.xz
mounted in repro: https://storage.googleapis.com/syzbot-assets/0049789b1ad4/mount_0.gz
WARNING: The mand mount option has been deprecated and
and is ignored by this kernel. Remove the mand
ocfs2: Mounting device (7,0) on (node local, slot 0) with writeback data mode.
6.1.114-syzkaller #0 Not tainted
------------------------------------------------------
syz-executor142/4240 is trying to acquire lock:
ffff88802fca6650 (sb_internal#2){.+.+}-{0:0}, at: ocfs2_setattr+0xd99/0x1f80 fs/ocfs2/file.c:1260
ffff88806f8acda0 (&oi->ip_alloc_sem){+.+.}-{3:3}, at: ocfs2_setattr+0xd87/0x1f80 fs/ocfs2/file.c:1259
lock_acquire+0x1f8/0x5a0 kernel/locking/lockdep.c:5662
down_write+0x36/0x60 kernel/locking/rwsem.c:1573
ocfs2_try_remove_refcount_tree+0xb2/0x330 fs/ocfs2/refcounttree.c:932
ocfs2_xattr_set+0xa4b/0x1930 fs/ocfs2/xattr.c:3674
ocfs2_set_acl+0x4cb/0x570 fs/ocfs2/acl.c:254
ocfs2_iop_set_acl+0x252/0x3c0 fs/ocfs2/acl.c:285
set_posix_acl fs/posix_acl.c:1160 [inline]
posix_acl_xattr_set+0x37b/0x3e0 fs/posix_acl.c:1189
__vfs_removexattr+0x3ce/0x410 fs/xattr.c:479
__vfs_removexattr_locked+0x1fe/0x410 fs/xattr.c:514
vfs_removexattr+0xff/0x2a0 fs/xattr.c:536
ovl_do_removexattr fs/overlayfs/overlayfs.h:270 [inline]
ovl_workdir_create+0x52c/0x9d0 fs/overlayfs/super.c:821
ovl_make_workdir fs/overlayfs/super.c:1389 [inline]
ovl_get_workdir+0x3b7/0x17b0 fs/overlayfs/super.c:1539
ovl_fill_super+0x1b85/0x2a20 fs/overlayfs/super.c:2095
mount_nodev+0x52/0xe0 fs/super.c:1489
legacy_get_tree+0xeb/0x180 fs/fs_context.c:632
vfs_get_tree+0x88/0x270 fs/super.c:1573
do_new_mount+0x2ba/0xb40 fs/namespace.c:3056
do_mount fs/namespace.c:3399 [inline]
__do_sys_mount fs/namespace.c:3607 [inline]
__se_sys_mount+0x2d5/0x3c0 fs/namespace.c:3584
do_syscall_x64 arch/x86/entry/common.c:51 [inline]
do_syscall_64+0x3b/0xb0 arch/x86/entry/common.c:81
entry_SYSCALL_64_after_hwframe+0x68/0xd2
lock_acquire+0x1f8/0x5a0 kernel/locking/lockdep.c:5662
down_read+0xad/0xa30 kernel/locking/rwsem.c:1520
ocfs2_init_acl+0x398/0x930 fs/ocfs2/acl.c:365
ocfs2_mknod+0x1f75/0x2e20 fs/ocfs2/namei.c:408
ocfs2_mkdir+0x1c0/0x4e0 fs/ocfs2/namei.c:655
vfs_mkdir+0x3b6/0x590 fs/namei.c:4106
do_mkdirat+0x225/0x360 fs/namei.c:4131
__do_sys_mkdirat fs/namei.c:4146 [inline]
__se_sys_mkdirat fs/namei.c:4144 [inline]
__x64_sys_mkdirat+0x85/0x90 fs/namei.c:4144
do_syscall_x64 arch/x86/entry/common.c:51 [inline]
do_syscall_64+0x3b/0xb0 arch/x86/entry/common.c:81
entry_SYSCALL_64_after_hwframe+0x68/0xd2
lock_acquire+0x1f8/0x5a0 kernel/locking/lockdep.c:5662
start_this_handle+0x1f71/0x21b0 fs/jbd2/transaction.c:463
jbd2__journal_start+0x2d1/0x5c0 fs/jbd2/transaction.c:520
jbd2_journal_start+0x25/0x30 fs/jbd2/transaction.c:559
ocfs2_start_trans+0x3c0/0x6f0 fs/ocfs2/journal.c:354
ocfs2_mknod+0x1638/0x2e20 fs/ocfs2/namei.c:359
ocfs2_mkdir+0x1c0/0x4e0 fs/ocfs2/namei.c:655
vfs_mkdir+0x3b6/0x590 fs/namei.c:4106
do_mkdirat+0x225/0x360 fs/namei.c:4131
__do_sys_mkdirat fs/namei.c:4146 [inline]
__se_sys_mkdirat fs/namei.c:4144 [inline]
__x64_sys_mkdirat+0x85/0x90 fs/namei.c:4144
do_syscall_x64 arch/x86/entry/common.c:51 [inline]
do_syscall_64+0x3b/0xb0 arch/x86/entry/common.c:81
entry_SYSCALL_64_after_hwframe+0x68/0xd2
lock_acquire+0x1f8/0x5a0 kernel/locking/lockdep.c:5662
down_read+0xad/0xa30 kernel/locking/rwsem.c:1520
ocfs2_start_trans+0x3b5/0x6f0 fs/ocfs2/journal.c:352
ocfs2_mknod+0x1638/0x2e20 fs/ocfs2/namei.c:359
ocfs2_mkdir+0x1c0/0x4e0 fs/ocfs2/namei.c:655
vfs_mkdir+0x3b6/0x590 fs/namei.c:4106
do_mkdirat+0x225/0x360 fs/namei.c:4131
__do_sys_mkdirat fs/namei.c:4146 [inline]
__se_sys_mkdirat fs/namei.c:4144 [inline]
__x64_sys_mkdirat+0x85/0x90 fs/namei.c:4144
do_syscall_x64 arch/x86/entry/common.c:51 [inline]
do_syscall_64+0x3b/0xb0 arch/x86/entry/common.c:81
entry_SYSCALL_64_after_hwframe+0x68/0xd2
validate_chain+0x1661/0x5950 kernel/locking/lockdep.c:3825
__lock_acquire+0x125b/0x1f80 kernel/locking/lockdep.c:5049
lock_acquire+0x1f8/0x5a0 kernel/locking/lockdep.c:5662
ocfs2_start_trans+0x2b0/0x6f0 fs/ocfs2/journal.c:350
ocfs2_setattr+0xd99/0x1f80 fs/ocfs2/file.c:1260
notify_change+0xce3/0xfc0 fs/attr.c:499
ovl_do_notify_change fs/overlayfs/overlayfs.h:142 [inline]
ovl_workdir_create+0x78b/0x9d0 fs/overlayfs/super.c:833
ovl_make_workdir fs/overlayfs/super.c:1389 [inline]
ovl_get_workdir+0x3b7/0x17b0 fs/overlayfs/super.c:1539
ovl_fill_super+0x1b85/0x2a20 fs/overlayfs/super.c:2095
mount_nodev+0x52/0xe0 fs/super.c:1489
legacy_get_tree+0xeb/0x180 fs/fs_context.c:632
vfs_get_tree+0x88/0x270 fs/super.c:1573
do_new_mount+0x2ba/0xb40 fs/namespace.c:3056
do_mount fs/namespace.c:3399 [inline]
__do_sys_mount fs/namespace.c:3607 [inline]
__se_sys_mount+0x2d5/0x3c0 fs/namespace.c:3584
do_syscall_x64 arch/x86/entry/common.c:51 [inline]
do_syscall_64+0x3b/0xb0 arch/x86/entry/common.c:81
entry_SYSCALL_64_after_hwframe+0x68/0xd2
5 locks held by syz-executor142/4240:
#0: ffff888078eec0e0 (&type->s_umount_key#42/1){+.+.}-{3:3}, at: alloc_super+0x217/0x930 fs/super.c:228
#1: ffff88802fca6460 (sb_writers#9){.+.+}-{0:0}, at: mnt_want_write+0x3b/0x80 fs/namespace.c:393
#2: ffff88806f8ac2c8 (&sb->s_type->i_mutex_key#15/1){+.+.}-{3:3}, at: inode_lock_nested include/linux/fs.h:793 [inline]
#2: ffff88806f8ac2c8 (&sb->s_type->i_mutex_key#15/1){+.+.}-{3:3}, at: ovl_workdir_create+0x159/0x9d0 fs/overlayfs/super.c:771
#3: ffff88806f8ad108 (&sb->s_type->i_mutex_key#17){+.+.}-{3:3}, at: inode_lock include/linux/fs.h:758 [inline]
#3: ffff88806f8ad108 (&sb->s_type->i_mutex_key#17){+.+.}-{3:3}, at: ovl_workdir_create+0x6ec/0x9d0 fs/overlayfs/super.c:832
#4: ffff88806f8acda0 (&oi->ip_alloc_sem){+.+.}-{3:3}, at: ocfs2_setattr+0xd87/0x1f80 fs/ocfs2/file.c:1259

stack backtrace:
CPU: 1 PID: 4240 Comm: syz-executor142 Not tainted 6.1.114-syzkaller #0
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 09/13/2024
Call Trace:
<TASK>
__dump_stack lib/dump_stack.c:88 [inline]
dump_stack_lvl+0x1e3/0x2cb lib/dump_stack.c:106
check_noncircular+0x2fa/0x3b0 kernel/locking/lockdep.c:2170
validate_chain+0x1661/0x5950 kernel/locking/lockdep.c:3825
__lock_acquire+0x125b/0x1f80 kernel/locking/lockdep.c:5049
lock_acquire+0x1f8/0x5a0 kernel/locking/lockdep.c:5662
ocfs2_start_trans+0x2b0/0x6f0 fs/ocfs2/journal.c:350
ocfs2_setattr+0xd99/0x1f80 fs/ocfs2/file.c:1260
notify_change+0xce3/0xfc0 fs/attr.c:499
ovl_do_notify_change fs/overlayfs/overlayfs.h:142 [inline]
ovl_workdir_create+0x78b/0x9d0 fs/overlayfs/super.c:833
ovl_make_workdir fs/overlayfs/super.c:1389 [inline]
ovl_get_workdir+0x3b7/0x17b0 fs/overlayfs/super.c:1539
ovl_fill_super+0x1b85/0x2a20 fs/overlayfs/super.c:2095
mount_nodev+0x52/0xe0 fs/super.c:1489
legacy_get_tree+0xeb/0x180 fs/fs_context.c:632
vfs_get_tree+0x88/0x270 fs/super.c:1573
do_new_mount+0x2ba/0xb40 fs/namespace.c:3056
do_mount fs/namespace.c:3399 [inline]
__do_sys_mount fs/namespace.c:3607 [inline]
__se_sys_mount+0x2d5/0x3c0 fs/namespace.c:3584
do_syscall_x64 arch/x86/entry/common.c:51 [inline]
do_syscall_64+0x3b/0xb0 arch/x86/entry/common.c:81
entry_SYSCALL_64_after_hwframe+0x68/0xd2
RIP: 0033:0x7f5a425ecab9
Code: 28 00 00 00 75 05 48 83 c4 28 c3 e8 61 17 00 00 90 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 c7 c1 b8 ff ff ff f7 d8 64 89 01 48
RSP: 002b:00007fffe5913c68 EFLAGS: 00000246 ORIG_RAX: 00000000000000a5
RAX: ffffffffffffffda RBX: 0031656c69662f2e RCX: 00007f5a425ecab9
RDX: 0000000020000080 RSI: 00000000200000c0 RDI: 0000000000000000
RBP: 00007f5a42663610 R08: 0000000020000040 R09: 0000000000000000
R10: 0000000000000000 R11: 0000000000000246 R12: 0000000000000001
R13: 00007fffe5913e38 R14: 00000000000000

syzbot suspects this issue could be fixed by backporting the following commit:

commit b36a5780cb44a16d4384639740d87e08d4cee627
git tree: upstream
Author: Christian Brauner <[email protected]>
Date: Fri Jun 16 13:54:19 2023 +0000

ovl: modify layer parameter parsing

bisection log: https://syzkaller.appspot.com/x/bisect.txt?x=12a52cf8580000
Please keep in mind that other backports might be required as well.

For information about bisection process see: https://goo.gl/tpsmEJ#bisection

bisection log: https://syzkaller.appspot.com/x/bisect.txt?x=1347def8580000
kernel config: https://syzkaller.appspot.com/x/.config?x=1fc30776feb70ea7
dashboard link: https://syzkaller.appspot.com/bug?extid=50d7961da48e2cadc59a
syz repro: https://syzkaller.appspot.com/x/repro.syz?x=117701df980000
C reproducer: https://syzkaller.appspot.com/x/repro.c?x=1460c218580000