Hello,
syzbot has tested the proposed patch but the reproducer is still triggering an issue:
KASAN: slab-use-after-free Read in ext4_convert_inline_data_nolock
loop0: detected capacity change from 0 to 2048
EXT4-fs (loop0): mounted filesystem 00000000-0000-0000-0000-000000000000 r/w without journal. Quota mode: none.
==================================================================
BUG: KASAN: slab-use-after-free in ext4_read_inline_data fs/ext4/inline.c:209 [inline]
BUG: KASAN: slab-use-after-free in ext4_convert_inline_data_nolock+0x316/0xe10 fs/ext4/inline.c:1188
Read of size 20 at addr ffff88801735b1a3 by task syz-executor.0/5398
CPU: 1 PID: 5398 Comm: syz-executor.0 Not tainted 6.7.0-rc1-syzkaller-00022-g6f861765464f #0
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 06/07/2024
Call Trace:
<TASK>
__dump_stack lib/dump_stack.c:88 [inline]
dump_stack_lvl+0x1e3/0x2d0 lib/dump_stack.c:106
print_address_description mm/kasan/report.c:364 [inline]
print_report+0x15f/0x540 mm/kasan/report.c:475
kasan_report+0x13e/0x170 mm/kasan/report.c:588
kasan_check_range+0x27a/0x290 mm/kasan/generic.c:187
__asan_memcpy+0x25/0x60 mm/kasan/shadow.c:105
ext4_read_inline_data fs/ext4/inline.c:209 [inline]
ext4_convert_inline_data_nolock+0x316/0xe10 fs/ext4/inline.c:1188
ext4_convert_inline_data+0x4d6/0x620 fs/ext4/inline.c:2041
ext4_fallocate+0x14b/0x1f40 fs/ext4/extents.c:4701
vfs_fallocate+0x54d/0x6b0 fs/open.c:324
ksys_fallocate fs/open.c:347 [inline]
__do_sys_fallocate fs/open.c:355 [inline]
__se_sys_fallocate fs/open.c:353 [inline]
__x64_sys_fallocate+0xb9/0x100 fs/open.c:353
do_syscall_x64 arch/x86/entry/common.c:51 [inline]
do_syscall_64+0x40/0x110 arch/x86/entry/common.c:82
entry_SYSCALL_64_after_hwframe+0x63/0x6b
RIP: 0033:0x7f870a47c959
Code: 28 00 00 00 75 05 48 83 c4 28 c3 e8 e1 20 00 00 90 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 c7 c1 b0 ff ff ff f7 d8 64 89 01 48
RSP: 002b:00007f870b28c0c8 EFLAGS: 00000246 ORIG_RAX: 000000000000011d
RAX: ffffffffffffffda RBX: 00007f870a59bf80 RCX: 00007f870a47c959
RDX: 0000000000000000 RSI: 0000000000000000 RDI: 0000000000000004
RBP: 00007f870a4d8c88 R08: 0000000000000000 R09: 0000000000000000
R10: 0000000000008000 R11: 0000000000000246 R12: 0000000000000000
R13: 000000000000000b R14: 00007f870a59bf80 R15: 00007fffb2c730b8
</TASK>
Allocated by task 5375:
kasan_save_stack mm/kasan/common.c:45 [inline]
kasan_set_track+0x4b/0x70 mm/kasan/common.c:52
__kasan_slab_alloc+0x62/0x70 mm/kasan/common.c:328
kasan_slab_alloc include/linux/kasan.h:188 [inline]
slab_post_alloc_hook+0x6c/0x3b0 mm/slab.h:763
slab_alloc_node mm/slub.c:3478 [inline]
slab_alloc mm/slub.c:3486 [inline]
__kmem_cache_alloc_lru mm/slub.c:3493 [inline]
kmem_cache_alloc+0x1b6/0x330 mm/slub.c:3502
getname_flags+0xb8/0x4f0 fs/namei.c:140
do_sys_openat2+0xce/0x1c0 fs/open.c:1434
do_sys_open fs/open.c:1455 [inline]
__do_sys_openat fs/open.c:1471 [inline]
__se_sys_openat fs/open.c:1466 [inline]
__x64_sys_openat+0x243/0x290 fs/open.c:1466
do_syscall_x64 arch/x86/entry/common.c:51 [inline]
do_syscall_64+0x40/0x110 arch/x86/entry/common.c:82
entry_SYSCALL_64_after_hwframe+0x63/0x6b
Freed by task 5375:
kasan_save_stack mm/kasan/common.c:45 [inline]
kasan_set_track+0x4b/0x70 mm/kasan/common.c:52
kasan_save_free_info+0x24/0x40 mm/kasan/generic.c:522
____kasan_slab_free+0xd6/0x120 mm/kasan/common.c:236
kasan_slab_free include/linux/kasan.h:164 [inline]
slab_free_hook mm/slub.c:1800 [inline]
slab_free_freelist_hook mm/slub.c:1826 [inline]
slab_free mm/slub.c:3809 [inline]
kmem_cache_free+0x28f/0x4f0 mm/slub.c:3831
do_sys_openat2+0x176/0x1c0 fs/open.c:1448
do_sys_open fs/open.c:1455 [inline]
__do_sys_openat fs/open.c:1471 [inline]
__se_sys_openat fs/open.c:1466 [inline]
__x64_sys_openat+0x243/0x290 fs/open.c:1466
do_syscall_x64 arch/x86/entry/common.c:51 [inline]
do_syscall_64+0x40/0x110 arch/x86/entry/common.c:82
entry_SYSCALL_64_after_hwframe+0x63/0x6b
The buggy address belongs to the object at ffff88801735a200
which belongs to the cache names_cache of size 4096
The buggy address is located 4003 bytes inside of
freed 4096-byte region [ffff88801735a200, ffff88801735b200)
The buggy address belongs to the physical page:
page:ffffea00005cd600 refcount:1 mapcount:0 mapping:0000000000000000 index:0x0 pfn:0x17358
head:ffffea00005cd600 order:3 entire_mapcount:0 nr_pages_mapped:0 pincount:0
flags: 0xfff00000000840(slab|head|node=0|zone=1|lastcpupid=0x7ff)
page_type: 0xffffffff()
raw: 00fff00000000840 ffff888014a4c780 dead000000000122 0000000000000000
raw: 0000000000000000 0000000000070007 00000001ffffffff 0000000000000000
page dumped because: kasan: bad access detected
page_owner tracks the page as allocated
page last allocated via order 3, migratetype Unmovable, gfp_mask 0x1d20c0(__GFP_IO|__GFP_FS|__GFP_NOWARN|__GFP_NORETRY|__GFP_COMP|__GFP_NOMEMALLOC|__GFP_HARDWALL), pid 5375, tgid 5375 (modprobe), ts 75851250888, free_ts 75785638652
set_page_owner include/linux/page_owner.h:31 [inline]
post_alloc_hook+0x1d2/0x1f0 mm/page_alloc.c:1537
prep_new_page mm/page_alloc.c:1544 [inline]
get_page_from_freelist+0x3376/0x3500 mm/page_alloc.c:3312
__alloc_pages+0x251/0x660 mm/page_alloc.c:4568
alloc_pages_mpol+0x3da/0x640 mm/mempolicy.c:2133
alloc_slab_page+0x6a/0x150 mm/slub.c:1870
allocate_slab mm/slub.c:2017 [inline]
new_slab+0x84/0x2d0 mm/slub.c:2070
___slab_alloc+0xc75/0x1300 mm/slub.c:3223
__slab_alloc mm/slub.c:3322 [inline]
__slab_alloc_node mm/slub.c:3375 [inline]
slab_alloc_node mm/slub.c:3468 [inline]
slab_alloc mm/slub.c:3486 [inline]
__kmem_cache_alloc_lru mm/slub.c:3493 [inline]
kmem_cache_alloc+0x213/0x330 mm/slub.c:3502
getname_flags+0xb8/0x4f0 fs/namei.c:140
do_sys_openat2+0xce/0x1c0 fs/open.c:1434
do_sys_open fs/open.c:1455 [inline]
__do_sys_openat fs/open.c:1471 [inline]
__se_sys_openat fs/open.c:1466 [inline]
__x64_sys_openat+0x243/0x290 fs/open.c:1466
do_syscall_x64 arch/x86/entry/common.c:51 [inline]
do_syscall_64+0x40/0x110 arch/x86/entry/common.c:82
entry_SYSCALL_64_after_hwframe+0x63/0x6b
page last free stack trace:
reset_page_owner include/linux/page_owner.h:24 [inline]
free_pages_prepare mm/page_alloc.c:1137 [inline]
free_unref_page_prepare+0x915/0xa30 mm/page_alloc.c:2347
free_unref_page+0x33/0x3e0 mm/page_alloc.c:2487
discard_slab mm/slub.c:2116 [inline]
__unfreeze_partials+0x1dc/0x220 mm/slub.c:2655
put_cpu_partial+0x17b/0x250 mm/slub.c:2731
__slab_free+0x2b2/0x380 mm/slub.c:3679
qlink_free mm/kasan/quarantine.c:168 [inline]
qlist_free_all+0x75/0xd0 mm/kasan/quarantine.c:187
kasan_quarantine_reduce+0x147/0x160 mm/kasan/quarantine.c:294
__kasan_slab_alloc+0x1f/0x70 mm/kasan/common.c:305
kasan_slab_alloc include/linux/kasan.h:188 [inline]
slab_post_alloc_hook+0x6c/0x3b0 mm/slab.h:763
slab_alloc_node mm/slub.c:3478 [inline]
kmem_cache_alloc_node+0x1a5/0x380 mm/slub.c:3523
alloc_task_struct_node kernel/fork.c:173 [inline]
dup_task_struct+0x57/0x7d0 kernel/fork.c:1110
copy_process+0x5cd/0x3fb0 kernel/fork.c:2332
kernel_clone+0x219/0x8c0 kernel/fork.c:2907
__do_sys_clone kernel/fork.c:3050 [inline]
__se_sys_clone kernel/fork.c:3034 [inline]
__x64_sys_clone+0x254/0x2a0 kernel/fork.c:3034
do_syscall_x64 arch/x86/entry/common.c:51 [inline]
do_syscall_64+0x40/0x110 arch/x86/entry/common.c:82
entry_SYSCALL_64_after_hwframe+0x63/0x6b
Memory state around the buggy address:
ffff88801735b080: fb fb fb fb fb fb fb fb fb fb fb fb fb fb fb fb
ffff88801735b100: fb fb fb fb fb fb fb fb fb fb fb fb fb fb fb fb
>ffff88801735b180: fb fb fb fb fb fb fb fb fb fb fb fb fb fb fb fb
^
ffff88801735b200: fc fc fc fc fc fc fc fc fc fc fc fc fc fc fc fc
ffff88801735b280: fc fc fc fc fc fc fc fc fc fc fc fc fc fc fc fc
==================================================================
Tested on:
commit: 6f861765 fs: Block writes to mounted block devices
git tree:
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
console output:
https://syzkaller.appspot.com/x/log.txt?x=130d0ac1980000
kernel config:
https://syzkaller.appspot.com/x/.config?x=6bec0297b0bf5206
dashboard link:
https://syzkaller.appspot.com/bug?extid=824b138c39c77ad6775f
compiler: Debian clang version 15.0.6, GNU ld (GNU Binutils for Debian) 2.40
Note: no patches were applied.