[syzbot] [ocfs2?] kernel BUG in ocfs2_set_new_buffer_uptodate (2)

Hello,

syzbot found the following issue on:

HEAD commit: 499551201b5f Merge tag 'arm64-fixes' of git://git.kernel.o..
git tree: upstream
console+strace: https://syzkaller.appspot.com/x/log.txt?x=13a76f30580000
kernel config: https://syzkaller.appspot.com/x/.config?x=6a2b862bf4a5409f
dashboard link: https://syzkaller.appspot.com/bug?extid=7aef76bdb53b83d62a9e
compiler: Debian clang version 15.0.6, GNU ld (GNU Binutils for Debian) 2.40
syz repro: https://syzkaller.appspot.com/x/repro.syz?x=17483cf8580000
C reproducer: https://syzkaller.appspot.com/x/repro.c?x=17a76f30580000

Downloadable assets:
disk image: https://storage.googleapis.com/syzbot-assets/12df04796e30/disk-49955120.raw.xz
vmlinux: https://storage.googleapis.com/syzbot-assets/48be851df472/vmlinux-49955120.xz
kernel image: https://storage.googleapis.com/syzbot-assets/ca727608fc80/bzImage-49955120.xz
mounted in repro: https://storage.googleapis.com/syzbot-assets/afa847f269d7/mount_0.gz

Bisection is inconclusive: the issue happens on the oldest tested release.

bisection log: https://syzkaller.appspot.com/x/bisect.txt?x=14de1fe8580000
final oops: https://syzkaller.appspot.com/x/report.txt?x=16de1fe8580000
console output: https://syzkaller.appspot.com/x/log.txt?x=12de1fe8580000

IMPORTANT: if you fix the issue, please add the following tag to the commit:
Reported-by: [email protected]

ocfs2: Mounting device (7,0) on (node local, slot 0) with ordered data mode.
------------[ cut here ]------------
kernel BUG at fs/ocfs2/uptodate.c:509!
Oops: invalid opcode: 0000 [#1] PREEMPT SMP KASAN NOPTI
CPU: 0 UID: 0 PID: 5831 Comm: syz-executor214 Not tainted 6.13.0-rc3-syzkaller-00209-g499551201b5f #0
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 09/13/2024
RIP: 0010:ocfs2_set_new_buffer_uptodate+0x145/0x160 fs/ocfs2/uptodate.c:509
Code: 03 42 80 3c 20 00 74 08 48 89 df e8 75 af 63 fe 4c 8b 1b 4c 89 ff 5b 41 5c 41 5d 41 5e 41 5f e9 31 6c 29 08 e8 7c 4e fd fd 90 <0f> 0b e8 74 4e fd fd 90 0f 0b e8 6c 4e fd fd 90 0f 0b e8 64 4e fd
RSP: 0018:ffffc900033cfa30 EFLAGS: 00010293
RAX: ffffffff83a22574 RBX: 0000000000000001 RCX: ffff888034a03c00
RDX: 0000000000000000 RSI: 0000000000000001 RDI: 0000000000000000
RBP: ffffc900033cfcf0 R08: ffffffff83a2245e R09: 1ffffffff2032fae
R10: dffffc0000000000 R11: fffffbfff2032faf R12: ffff8880754fcfb8
R13: dffffc0000000000 R14: ffff88807b765570 R15: ffff8880754f8830
FS: 0000555565eff380(0000) GS:ffff8880b8600000(0000) knlGS:0000000000000000
CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033
CR2: 000000000066c7e0 CR3: 0000000033ee0000 CR4: 0000000000350ef0
Call Trace:
<TASK>
ocfs2_group_add+0x3a3/0x15a0 fs/ocfs2/resize.c:507
ocfs2_ioctl+0x65e/0x7d0 fs/ocfs2/ioctl.c:891
vfs_ioctl fs/ioctl.c:51 [inline]
__do_sys_ioctl fs/ioctl.c:906 [inline]
__se_sys_ioctl+0xf7/0x170 fs/ioctl.c:892
do_syscall_x64 arch/x86/entry/common.c:52 [inline]
do_syscall_64+0xf3/0x230 arch/x86/entry/common.c:83
entry_SYSCALL_64_after_hwframe+0x77/0x7f
RIP: 0033:0x7f0b996cd6f9
Code: 28 00 00 00 75 05 48 83 c4 28 c3 e8 61 17 00 00 90 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 c7 c1 b8 ff ff ff f7 d8 64 89 01 48
RSP: 002b:00007ffcd6119cf8 EFLAGS: 00000246 ORIG_RAX: 0000000000000010
RAX: ffffffffffffffda RBX: 0031656c69662f2e RCX: 00007f0b996cd6f9
RDX: 00000000200000c0 RSI: 0000000040186f02 RDI: 0000000000000004
RBP: 00007f0b99744610 R08: 0000000000000000 R09: 00007ffcd6119ec8
R10: 00007f0b99708ab3 R11: 0000000000000246 R12: 0000000000000001
R13: 00007ffcd6119eb8 R14: 0000000000000001 R15: 0000000000000001
</TASK>
Modules linked in:
---[ end trace 0000000000000000 ]---
RIP: 0010:ocfs2_set_new_buffer_uptodate+0x145/0x160 fs/ocfs2/uptodate.c:509
Code: 03 42 80 3c 20 00 74 08 48 89 df e8 75 af 63 fe 4c 8b 1b 4c 89 ff 5b 41 5c 41 5d 41 5e 41 5f e9 31 6c 29 08 e8 7c 4e fd fd 90 <0f> 0b e8 74 4e fd fd 90 0f 0b e8 6c 4e fd fd 90 0f 0b e8 64 4e fd
RSP: 0018:ffffc900033cfa30 EFLAGS: 00010293
RAX: ffffffff83a22574 RBX: 0000000000000001 RCX: ffff888034a03c00
RDX: 0000000000000000 RSI: 0000000000000001 RDI: 0000000000000000
RBP: ffffc900033cfcf0 R08: ffffffff83a2245e R09: 1ffffffff2032fae
R10: dffffc0000000000 R11: fffffbfff2032faf R12: ffff8880754fcfb8
R13: dffffc0000000000 R14: ffff88807b765570 R15: ffff8880754f8830
FS: 0000555565eff380(0000) GS:ffff8880b8600000(0000) knlGS:0000000000000000
CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033
CR2: 000000000066c7e0 CR3: 0000000033ee0000 CR4: 0000000000350ef0


---
This report is generated by a bot. It may contain errors.
See https://goo.gl/tpsmEJ for more information about syzbot.
syzbot engineers can be reached at [email protected].

syzbot will keep track of this issue. See:
https://goo.gl/tpsmEJ#status for how to communicate with syzbot.
For information about bisection process see: https://goo.gl/tpsmEJ#bisection

If the report is already addressed, let syzbot know by replying with:
#syz fix: exact-commit-title

If you want syzbot to run the reproducer, reply with:
#syz test: git://repo/address.git branch-or-commit-hash
If you attach or paste a git patch, syzbot will apply it before testing.

If you want to overwrite report's subsystems, reply with:
#syz set subsystems: new-subsystem
(See the list of subsystem names on the web dashboard)

If the report is a duplicate of another one, reply with:
#syz dup: exact-subject-of-another-report

If you want to undo deduplication, reply with:
#syz undup

For archival purposes, forwarding an incoming command email to
[email protected], [email protected].

***

Subject: Re: kernel BUG in ocfs2_set_new_buffer_uptodate()
Author: [email protected]

#syz test https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git 9b2ffa6148b1e4468d08f7e0e7e371c43cac9ffe

diff --git a/fs/ocfs2/resize.c b/fs/ocfs2/resize.c
index b0733c08ed13..6d6979fdd3a2 100644
--- a/fs/ocfs2/resize.c
+++ b/fs/ocfs2/resize.c
@@ -504,7 +504,7 @@ int ocfs2_group_add(struct inode *inode, struct ocfs2_new_group_input *input)
goto out_unlock;
}

- ocfs2_set_new_buffer_uptodate(INODE_CACHE(inode), group_bh);
+ ocfs2_set_buffer_uptodate(INODE_CACHE(inode), group_bh);

ret = ocfs2_verify_group_and_input(main_bm_inode, fe, input, group_bh);
if (ret) {

Hello,

syzbot has tested the proposed patch and the reproducer did not trigger any issue:

Reported-by: [email protected]
Tested-by: [email protected]

Tested on:

commit: 9b2ffa61 Merge tag 'mtd/fixes-for-6.13-rc5' of git://g..
git tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
console output: https://syzkaller.appspot.com/x/log.txt?x=12a15adf980000
kernel config: https://syzkaller.appspot.com/x/.config?x=d269ef41b9262400
patch: https://syzkaller.appspot.com/x/patch.diff?x=11ae5adf980000

Note: testing is done by a robot and is best-effort only.

#syz test https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git d6ef8b40d075c425f548002d2f35ae3f06e9cf96

diff --git a/fs/ocfs2/dir.c b/fs/ocfs2/dir.c
index 213206ebdd58..3bfbc166d1fe 100644
--- a/fs/ocfs2/dir.c
+++ b/fs/ocfs2/dir.c
@@ -416,6 +416,9 @@ static struct buffer_head *ocfs2_find_entry_id(const char *name,
if (found == 1)
return di_bh;

+ /* Cached by ocfs2_read_blocks() so remove it. */
+ ocfs2_remove_from_cache(INODE_CACHE(dir), di_bh);
+
brelse(di_bh);
out:
return NULL;

Hello,

syzbot has tested the proposed patch but the reproducer is still triggering an issue:
kernel BUG in ocfs2_set_new_buffer_uptodate
Oops: invalid opcode: 0000 [#1] PREEMPT SMP KASAN PTI
CPU: 0 UID: 0 PID: 10858 Comm: syz.3.713 Not tainted 6.13.0-rc4-syzkaller-00054-gd6ef8b40d075-dirty #0
Code: 03 42 80 3c 20 00 74 08 48 89 df e8 65 ae 63 fe 4c 8b 1b 4c 89 ff 5b 41 5c 41 5d 41 5e 41 5f 41 ff e3 cc 90 e8 ac d1 ff fd 90 <0f> 0b e8 a4 d1 ff fd 90 0f 0b e8 9c d1 ff fd 90 0f 0b e8 94 d1 ff
RSP: 0018:ffffc9000c947a30 EFLAGS: 00010293
RAX: ffffffff839fa234 RBX: 0000000000000001 RCX: ffff888030438000
RBP: ffffc9000c947cf0 R08: ffffffff839fa11e R09: 1ffffffff2030a4e
R10: dffffc0000000000 R11: fffffbfff2030a4f R12: ffff8880586616b8
R13: dffffc0000000000 R14: ffff88805b8eaae0 R15: ffff88805b9f8830
FS: 00007fd029a316c0(0000) GS:ffff8880b8600000(0000) knlGS:0000000000000000
CR2: 00007fe9b947f000 CR3: 00000000283fa000 CR4: 00000000003526f0
DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000
DR3: 0000000000000000 DR6: 00000000fffe0ff0 DR7: 0000000000000400
__se_sys_ioctl+0xf5/0x170 fs/ioctl.c:892
RIP: 0033:0x7fd028b85d29
Code: ff ff c3 66 2e 0f 1f 84 00 00 00 00 00 0f 1f 40 00 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 c7 c1 a8 ff ff ff f7 d8 64 89 01 48
RSP: 002b:00007fd029a31038 EFLAGS: 00000246 ORIG_RAX: 0000000000000010
RAX: ffffffffffffffda RBX: 00007fd028d76080 RCX: 00007fd028b85d29
RBP: 00007fd028c01b08 R08: 0000000000000000 R09: 0000000000000000
R10: 0000000000000000 R11: 0000000000000246 R12: 0000000000000000
R13: 0000000000000000 R14: 00007fd028d76080 R15: 00007ffd6ac0c628
Code: 03 42 80 3c 20 00 74 08 48 89 df e8 65 ae 63 fe 4c 8b 1b 4c 89 ff 5b 41 5c 41 5d 41 5e 41 5f 41 ff e3 cc 90 e8 ac d1 ff fd 90 <0f> 0b e8 a4 d1 ff fd 90 0f 0b e8 9c d1 ff fd 90 0f 0b e8 94 d1 ff
RSP: 0018:ffffc9000c947a30 EFLAGS: 00010293
RAX: ffffffff839fa234 RBX: 0000000000000001 RCX: ffff888030438000
RBP: ffffc9000c947cf0 R08: ffffffff839fa11e R09: 1ffffffff2030a4e
R10: dffffc0000000000 R11: fffffbfff2030a4f R12: ffff8880586616b8
R13: dffffc0000000000 R14: ffff88805b8eaae0 R15: ffff88805b9f8830
FS: 00007fd029a316c0(0000) GS:ffff8880b8600000(0000) knlGS:0000000000000000
CR2: 00007fe9ba1ff000 CR3: 00000000283fa000 CR4: 00000000003526f0
DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000
DR3: 0000000000000000 DR6: 00000000fffe0ff0 DR7: 0000000000000400


Tested on:

commit: d6ef8b40 Merge tag 'sound-6.13-rc5' of git://git.kerne..
git tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
console output: https://syzkaller.appspot.com/x/log.txt?x=1319d90f980000
kernel config: https://syzkaller.appspot.com/x/.config?x=4c4096b0d467a682
patch: https://syzkaller.appspot.com/x/patch.diff?x=1520badf980000