[L] Change in dart/sdk[main]: [analysis_server] Update CodeActionsProducers to support either kind ...
0 views
Skip to first unread message
Samuel Rawlins (Gerrit)
May 7, 2025, 5:11:38 PM (6 days ago) May 7
to Danny Tuppeny, Brian Wilkerson, [email protected], [email protected]
Attention needed from Brian Wilkerson and Danny Tuppeny
Samuel Rawlins voted Code-Review+1![]( "Open in Gerrit")
| Code-Review | +1 |
Related details
Attention is currently required from:
- Brian Wilkerson
- Danny Tuppeny
Submit Requirements:
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Brian Wilkerson (Gerrit)
May 7, 2025, 5:26:48 PM (6 days ago) May 7
to Danny Tuppeny, Brian Wilkerson, Commit Queue, Samuel Rawlins, [email protected], [email protected]
Attention needed from Danny Tuppeny and Samuel Rawlins
Brian Wilkerson voted Code-Review+1![]( "Open in Gerrit")
| Code-Review | +1 |
Related details
Attention is currently required from:
- Danny Tuppeny
- Samuel Rawlins
Submit Requirements:
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Brian Wilkerson (Gerrit)
May 7, 2025, 6:06:18 PM (6 days ago) May 7
to Danny Tuppeny, Brian Wilkerson, Commit Queue, Samuel Rawlins, [email protected], [email protected]
Attention needed from Danny Tuppeny and Samuel Rawlins
Brian Wilkerson voted Commit-Queue+2![]( "Open in Gerrit")
| Commit-Queue | +2 |
Related details
Attention is currently required from:
- Danny Tuppeny
- Samuel Rawlins
Submit Requirements:
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Danny Tuppeny (Gerrit)
May 7, 2025, 6:36:09 PM (6 days ago) May 7
to Brian Wilkerson, Commit Queue, Samuel Rawlins, [email protected], [email protected]
Attention needed from Brian Wilkerson and Samuel Rawlins
Danny Tuppeny added 1 comment![]( "Open in Gerrit")
Patchset-level comments
File-level comment, Patchset 2 (Latest):
Danny Tuppeny . resolved
The other change landing caused Gerrit to mark this as conflicting so I've rebased in the UI (there were no actual conflicts, as this CL was already based on that previous one). You'll have to trigger this one again.
Thanks!
Related details
Attention is currently required from:
- Brian Wilkerson
- Samuel Rawlins
Submit Requirements:
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Brian Wilkerson (Gerrit)
May 7, 2025, 6:41:08 PM (6 days ago) May 7
to Danny Tuppeny, Brian Wilkerson, Commit Queue, Samuel Rawlins, [email protected], [email protected]
Attention needed from Danny Tuppeny and Samuel Rawlins
Brian Wilkerson voted Commit-Queue+2![]( "Open in Gerrit")
Attention is currently required from:
- Danny Tuppeny
- Samuel Rawlins
Submit Requirements:
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Commit Queue (Gerrit)
May 7, 2025, 6:41:28 PM (6 days ago) May 7
to Danny Tuppeny, Brian Wilkerson, Samuel Rawlins, [email protected], [email protected]
Commit Queue submitted the change![]( "Open in Gerrit")
Unreviewed changes
1 is the latest approved patch-set.
No files were changed between the latest approved patch-set and the submitted one.
Change information
Commit message:
[analysis_server] Update CodeActionsProducers to support either kind of CodeAction
No functional changes, just some additional refactors extracted from an upcoming CL to make it easier to review. This updates the `CodeActionProducer`s (and related code in `CodeActionComputer`) so their signatures use `CodeAction` instead of `CodeActionLiteral`, which means this code will be able to support `Command` code actions in future.
Mostly it's trivial changes, but the code that de-dupes and merges actions needed a little more updating to handle the different kinds.
Change-Id: Ic2255b2d9864b6974a542d1d3ee3b099c4d5ea32
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/427222
Reviewed-by: Samuel Rawlins <[email protected]>
Commit-Queue: Brian Wilkerson <[email protected]>
Reviewed-by: Brian Wilkerson <[email protected]>
Files:
- A pkg/analysis_server/lib/src/lsp/extensions/code_action.dart
- M pkg/analysis_server/lib/src/lsp/handlers/code_actions/abstract_code_actions_producer.dart
- M pkg/analysis_server/lib/src/lsp/handlers/code_actions/analysis_options.dart
- M pkg/analysis_server/lib/src/lsp/handlers/code_actions/code_action_computer.dart
- M pkg/analysis_server/lib/src/lsp/handlers/code_actions/dart.dart
- M pkg/analysis_server/lib/src/lsp/handlers/code_actions/plugins.dart
- M pkg/analysis_server/lib/src/lsp/handlers/code_actions/pubspec.dart
- M pkg/analysis_server/test/lsp/code_actions_abstract.dart
- M pkg/analysis_server/test/lsp/code_actions_assists_test.dart
- M pkg/analysis_server/test/lsp/code_actions_fixes_test.dart
- M pkg/analysis_server/test/src/services/refactoring/convert_all_formal_parameters_to_named_test.dart
- M pkg/analysis_server/test/src/services/refactoring/convert_selected_formal_parameters_to_named_test.dart
- M pkg/analysis_server/test/src/services/refactoring/move_selected_formal_parameters_left_test.dart
- M pkg/analysis_server/test/src/services/refactoring/move_top_level_to_file_test.dart
- M pkg/analysis_server/test/src/services/refactoring/refactoring_test_support.dart
- M pkg/analysis_server/test/utils/lsp_protocol_extensions.dart
Change size: L
Delta: 16 files changed, 158 insertions(+), 103 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Brian Wilkerson, +1 by Samuel Rawlins
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages