[M] Change in dart/sdk[main]: [observatory] Fix broken infobox and rare source view errors.
0 views
Skip to first unread message
Alexander Aprelev (Gerrit)
May 7, 2025, 7:53:46 PM (8 days ago) May 7
to Alexander Aprelev, Ryan Macnak, Ben Konyi, [email protected], [email protected]
Attention needed from Ryan Macnak
Alexander Aprelev voted Commit-Queue+1![]( "Open in Gerrit")
| Commit-Queue | +1 |
Related details
Attention is currently required from:
- Ryan Macnak
Submit Requirements:
Code-Review
Commit-Message-Has-TEST
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Ryan Macnak (Gerrit)
May 8, 2025, 12:31:40 AM (8 days ago) May 8
to Alexander Aprelev, Commit Queue, Ben Konyi, [email protected], [email protected]
Attention needed from Alexander Aprelev
Ryan Macnak voted Code-Review+1![]( "Open in Gerrit")
Attention is currently required from:
- Alexander Aprelev
Submit Requirements:
Code-Review
Commit-Message-Has-TEST
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Alexander Aprelev (Gerrit)
May 8, 2025, 12:31:52 AM (8 days ago) May 8
to Alexander Aprelev, Ryan Macnak, Commit Queue, Ben Konyi, [email protected], [email protected]
Alexander Aprelev voted Commit-Queue+2![]( "Open in Gerrit")
Submit Requirements:
Code-Review
Commit-Message-Has-TEST
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Commit Queue (Gerrit)
May 8, 2025, 12:32:04 AM (8 days ago) May 8
to Alexander Aprelev, Ryan Macnak, Ben Konyi, [email protected], [email protected]
Commit Queue submitted the change![]( "Open in Gerrit")
Change information
Commit message:
[observatory] Fix broken infobox and rare source view errors.
Element-handling code doesn't work properly with dynamic types so
explicit types are required.
TokenToLine info can be absent, handle nulls there to prevent crashes.
TEST=manually
Change-Id: Ie223a785e12ded8c344ee3c5256d1f6a3b544528
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/427301
Commit-Queue: Alexander Aprelev <[email protected]>
Reviewed-by: Ryan Macnak <[email protected]>
Files:
- M runtime/observatory/lib/src/elements/script_inset.dart
- M runtime/observatory/lib/src/service/object.dart
Change size: M
Delta: 2 files changed, 42 insertions(+), 37 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Ryan Macnak
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages