[S] Change in dart/sdk[main]: Issue 60683. Fix for UnimplementedError from ElementImpl2.enclosingEl...

0 views
Skip to first unread message

Brian Wilkerson (Gerrit)

unread,
May 7, 2025, 7:28:00 PM (4 days ago) May 7
to Konstantin Shcheglov, Brian Wilkerson, Commit Queue, [email protected], [email protected]
Attention needed from Konstantin Shcheglov

Brian Wilkerson voted Code-Review+1

Code-Review+1
Open in Gerrit

Related details

Attention is currently required from:
  • Konstantin Shcheglov
Submit Requirements:
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: sdk
Gerrit-Branch: main
Gerrit-Change-Id: I122eed163c8f713ca1dd416c194eb432f23802de
Gerrit-Change-Number: 427300
Gerrit-PatchSet: 1
Gerrit-Owner: Konstantin Shcheglov <[email protected]>
Gerrit-Reviewer: Brian Wilkerson <[email protected]>
Gerrit-Reviewer: Konstantin Shcheglov <[email protected]>
Gerrit-CC: Commit Queue <[email protected]>
Gerrit-Attention: Konstantin Shcheglov <[email protected]>
Gerrit-Comment-Date: Wed, 07 May 2025 16:27:57 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Konstantin Shcheglov (Gerrit)

unread,
May 7, 2025, 10:15:00 PM (3 days ago) May 7
to Brian Wilkerson, Commit Queue, [email protected], [email protected]

Konstantin Shcheglov voted Commit-Queue+2

Commit-Queue+2
Open in Gerrit

Related details

Attention set is empty
Submit Requirements:
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: sdk
Gerrit-Branch: main
Gerrit-Change-Id: I122eed163c8f713ca1dd416c194eb432f23802de
Gerrit-Change-Number: 427300
Gerrit-PatchSet: 1
Gerrit-Owner: Konstantin Shcheglov <[email protected]>
Gerrit-Reviewer: Brian Wilkerson <[email protected]>
Gerrit-Reviewer: Konstantin Shcheglov <[email protected]>
Gerrit-CC: Commit Queue <[email protected]>
Gerrit-Comment-Date: Wed, 07 May 2025 19:14:47 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Commit Queue (Gerrit)

unread,
May 7, 2025, 10:15:04 PM (3 days ago) May 7
to Konstantin Shcheglov, Brian Wilkerson, [email protected], [email protected]

Commit Queue submitted the change

Change information

Commit message:
Issue 60683. Fix for UnimplementedError from ElementImpl2.enclosingElement2, when GenericFunctionTypeElementImpl2.
Change-Id: I122eed163c8f713ca1dd416c194eb432f23802de
Reviewed-by: Brian Wilkerson <[email protected]>
Commit-Queue: Konstantin Shcheglov <[email protected]>
Files:
  • M pkg/analyzer/lib/src/dart/element/element.dart
  • M pkg/analyzer/lib/src/test_utilities/find_node.dart
  • M pkg/analyzer/test/src/dart/resolution/generic_function_type_test.dart
Change size: S
Delta: 3 files changed, 18 insertions(+), 4 deletions(-)
Branch: refs/heads/main
Submit Requirements:
  • requirement satisfiedCode-Review: +1 by Brian Wilkerson
Open in Gerrit
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: merged
Gerrit-Project: sdk
Gerrit-Branch: main
Gerrit-Change-Id: I122eed163c8f713ca1dd416c194eb432f23802de
Gerrit-Change-Number: 427300
Gerrit-PatchSet: 2
Gerrit-Owner: Konstantin Shcheglov <[email protected]>
Gerrit-Reviewer: Brian Wilkerson <[email protected]>
Gerrit-Reviewer: Commit Queue <[email protected]>
Gerrit-Reviewer: Konstantin Shcheglov <[email protected]>
open
diffy
satisfied_requirement
Reply all
Reply to author
Forward
0 new messages