[XL] Change in dart/sdk[main]: Make `nodeCovering` a method on `CompilationUnitImpl` rather than an ...
0 views
Skip to first unread message
Brian Wilkerson (Gerrit)
May 7, 2025, 5:08:19 PM (11 days ago) May 7
to Brian Wilkerson, Konstantin Shcheglov, Jens Johansen, Commit Queue, [email protected], [email protected]
Attention needed from Konstantin Shcheglov
New activity on the change![]( "Open in Gerrit")
Related details
Attention is currently required from:
- Konstantin Shcheglov
Submit Requirements:
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Konstantin Shcheglov (Gerrit)
May 7, 2025, 6:59:19 PM (11 days ago) May 7
to Brian Wilkerson, Jens Johansen, Commit Queue, [email protected], [email protected]
Attention needed from Brian Wilkerson
Konstantin Shcheglov voted Code-Review+1![]( "Open in Gerrit")
Attention is currently required from:
- Brian Wilkerson
Submit Requirements:
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Brian Wilkerson (Gerrit)
May 7, 2025, 7:05:39 PM (11 days ago) May 7
to Brian Wilkerson, Konstantin Shcheglov, Jens Johansen, Commit Queue, [email protected], [email protected]
Brian Wilkerson voted Commit-Queue+2![]( "Open in Gerrit")
Submit Requirements:
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Commit Queue (Gerrit)
May 7, 2025, 7:05:56 PM (11 days ago) May 7
to Brian Wilkerson, Konstantin Shcheglov, Jens Johansen, [email protected], [email protected]
Commit Queue submitted the change![]( "Open in Gerrit")
Change information
Commit message:
Make `nodeCovering` a method on `CompilationUnitImpl` rather than an extension method
This allows us to traverse the children without needing to create lists.
It also allows us to iterate over lists of nodes more efficiently.
Tested against the script that computes fixes for 10,000 diagnostics,
I'm seeing the following result.
Before this CL the average time was 10692.4 ms.
After this CL the average time was 1900.0 ms.
That's just over an 82% improvement.
Change-Id: Ideff745288c8990e9948b22c5204d176af3cac6e
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/426904
Reviewed-by: Konstantin Shcheglov <[email protected]>
Commit-Queue: Brian Wilkerson <[email protected]>
Files:
- M pkg/analysis_server/lib/src/analysis_server.dart
- M pkg/analysis_server/lib/src/cider/rename.dart
- M pkg/analysis_server/lib/src/computer/computer_call_hierarchy.dart
- M pkg/analysis_server/lib/src/computer/computer_hover.dart
- M pkg/analysis_server/lib/src/computer/computer_lazy_type_hierarchy.dart
- M pkg/analysis_server/lib/src/computer/computer_selection_ranges.dart
- M pkg/analysis_server/lib/src/computer/computer_signature.dart
- M pkg/analysis_server/lib/src/computer/computer_type_arguments_signature.dart
- M pkg/analysis_server/lib/src/handler/legacy/edit_get_available_refactorings.dart
- M pkg/analysis_server/lib/src/lsp/handlers/code_actions/dart.dart
- M pkg/analysis_server/lib/src/lsp/handlers/commands/abstract_refactor.dart
- M pkg/analysis_server/lib/src/lsp/handlers/custom/editable_arguments/editable_arguments_mixin.dart
- M pkg/analysis_server/lib/src/lsp/handlers/custom/handler_augmentation.dart
- M pkg/analysis_server/lib/src/lsp/handlers/custom/handler_augmented.dart
- M pkg/analysis_server/lib/src/lsp/handlers/custom/handler_imports.dart
- M pkg/analysis_server/lib/src/lsp/handlers/custom/handler_super.dart
- M pkg/analysis_server/lib/src/lsp/handlers/handler_implementation.dart
- M pkg/analysis_server/lib/src/lsp/handlers/handler_inline_value.dart
- M pkg/analysis_server/lib/src/lsp/handlers/handler_references.dart
- M pkg/analysis_server/lib/src/lsp/handlers/handler_rename.dart
- M pkg/analysis_server/lib/src/lsp/handlers/handler_type_definition.dart
- M pkg/analysis_server/lib/src/services/completion/postfix/postfix_completion.dart
- M pkg/analysis_server/lib/src/services/completion/statement/statement_completion.dart
- M pkg/analysis_server/lib/src/services/correction/dart/add_diagnostic_property_reference.dart
- M pkg/analysis_server/lib/src/services/correction/dart/make_variable_not_final.dart
- M pkg/analysis_server/lib/src/services/flutter/widget_descriptions.dart
- M pkg/analysis_server/lib/src/services/refactoring/legacy/convert_method_to_getter.dart
- M pkg/analysis_server/lib/src/services/refactoring/legacy/extract_local.dart
- M pkg/analysis_server/lib/src/services/refactoring/legacy/extract_method.dart
- M pkg/analysis_server/lib/src/services/refactoring/legacy/extract_widget.dart
- M pkg/analysis_server/lib/src/services/refactoring/legacy/inline_local.dart
- M pkg/analysis_server/lib/src/services/refactoring/legacy/inline_method.dart
- M pkg/analysis_server/lib/src/services/refactoring/legacy/refactoring_manager.dart
- M pkg/analysis_server/lib/src/services/refactoring/legacy/rename_import.dart
- M pkg/analysis_server/lib/src/utilities/extensions/ast.dart
- M pkg/analysis_server_plugin/lib/edit/correction_utils.dart
- M pkg/analysis_server_plugin/lib/edit/dart/correction_producer.dart
- M pkg/analysis_server_plugin/lib/src/correction/assist_processor.dart
- M pkg/analysis_server_plugin/lib/src/utilities/selection.dart
- M pkg/analyzer/api.txt
- M pkg/analyzer/lib/src/dart/analysis/library_analyzer.dart
- M pkg/analyzer/lib/src/dart/analysis/search.dart
- M pkg/analyzer/lib/src/dart/ast/ast.dart
- M pkg/analyzer/lib/src/error/unicode_text_verifier.dart
- M pkg/analyzer/lib/utilities/extensions/ast.dart
- M pkg/analyzer/test/src/dart/ast/ast_test.dart
- M pkg/analyzer/test/src/dart/micro/simple_file_resolver_test.dart
- D pkg/analyzer/test/src/utilities/extensions/ast_test.dart
- M pkg/analyzer/test/src/utilities/extensions/test_all.dart
- M pkg/analyzer_plugin/lib/src/utilities/navigation/navigation_dart.dart
- M pkg/analyzer_plugin/test/support/abstract_single_unit.dart
Change size: XL
Delta: 51 files changed, 2246 insertions(+), 551 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Konstantin Shcheglov
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages