Dart Code Reviews

1–30 of 119199

All emails to this list are automatically generated when a code review is updated.

Please do not send emails to this list.

To learn how you can contribute, visit: https://code.google.com/p/dart/wiki/Contributing

To view all changes, visit: https://codereview.chromium.org/search?repo_guid=5387d39e155533a4abe4cc1bfe88223c824ee2ee

0 selected

Ryan Macnak (Gerrit), Alexander Aprelev (Gerrit)2

1:41 AM

[M] Change in dart/sdk[main]: [gardening] Fix analyzer findings on observatory.

Alexander Aprelev voted Commit-Queue+2 Commit-Queue +2 Open in Gerrit Related details Attention set

unread,

[M] Change in dart/sdk[main]: [gardening] Fix analyzer findings on observatory.

Alexander Aprelev voted Commit-Queue+2 Commit-Queue +2 Open in Gerrit Related details Attention set

1:41 AM

Konstantin Shcheglov (Gerrit), Brian Wilkerson (Gerrit)2

1:24 AM

[M] Change in dart/sdk[main]: Fine. Tracking annotations for element model objects.

Attention needed from Konstantin Shcheglov and Paul Berry Brian Wilkerson added 4 comments File pkg/

unread,

[M] Change in dart/sdk[main]: Fine. Tracking annotations for element model objects.

Attention needed from Konstantin Shcheglov and Paul Berry Brian Wilkerson added 4 comments File pkg/

1:24 AM

Alexander Aprelev (Gerrit), … Commit Queue (Gerrit)4

12:32 AM

[M] Change in dart/sdk[main]: [observatory] Fix broken infobox and rare source view errors.

Commit Queue submitted the change Change information Commit message: [observatory] Fix broken infobox

unread,

[M] Change in dart/sdk[main]: [observatory] Fix broken infobox and rare source view errors.

Commit Queue submitted the change Change information Commit message: [observatory] Fix broken infobox

12:32 AM

Ryan Macnak (Gerrit), Alexander Aprelev (Gerrit)3

12:28 AM

[M] Change in dart/sdk[main]: [infra] Refactor X64 sanitizer builders to match ARM64.

Ryan Macnak submitted the change Change information Commit message: [infra] Refactor X64 sanitizer

unread,

[M] Change in dart/sdk[main]: [infra] Refactor X64 sanitizer builders to match ARM64.

Ryan Macnak submitted the change Change information Commit message: [infra] Refactor X64 sanitizer

12:28 AM

Ryan Macnak (Gerrit), … Commit Queue (Gerrit)4

12:21 AM

[XS] Change in dart/sdk[main]: [test] Fix analysis supression for VMInternalsForTesting.

Commit Queue submitted the change Change information Commit message: [test] Fix analysis supression

unread,

[XS] Change in dart/sdk[main]: [test] Fix analysis supression for VMInternalsForTesting.

Commit Queue submitted the change Change information Commit message: [test] Fix analysis supression

12:21 AM

Paul Berry (Gerrit), … Konstantin Shcheglov (Gerrit)3

12:11 AM

[M] Change in dart/sdk[main]: Sort declarations in `mini_ast.dart` and `type_analyzer.dart`.

Attention needed from Paul Berry Konstantin Shcheglov voted Code-Review+1 Code-Review +1 Open in

unread,

[M] Change in dart/sdk[main]: Sort declarations in `mini_ast.dart` and `type_analyzer.dart`.

Attention needed from Paul Berry Konstantin Shcheglov voted Code-Review+1 Code-Review +1 Open in

12:11 AM

Kallen Tu (Gerrit), … Brian Wilkerson (Gerrit)11

May 7

[M] Change in dart/sdk[main]: [analyzer] Dot shorthands: Error - constructors with type parameters.

Kallen Tu voted Commit-Queue+2 Commit-Queue +2 Open in Gerrit Related details Attention set is empty

unread,

[M] Change in dart/sdk[main]: [analyzer] Dot shorthands: Error - constructors with type parameters.

Kallen Tu voted Commit-Queue+2 Commit-Queue +2 Open in Gerrit Related details Attention set is empty

May 7

Konstantin Shcheglov (Gerrit), … Commit Queue (Gerrit)3

May 7

[S] Change in dart/sdk[main]: analyzer_testing: move experiments library to analyzer_testing

Commit Queue submitted the change Change information Commit message: analyzer_testing: move

unread,

[S] Change in dart/sdk[main]: analyzer_testing: move experiments library to analyzer_testing

Commit Queue submitted the change Change information Commit message: analyzer_testing: move

May 7

Brian Wilkerson (Gerrit), … Commit Queue (Gerrit)4

May 7

[L] Change in dart/sdk[main]: Deprecate MemoryResourceProvider.convertPath in favor of extension

Commit Queue submitted the change Change information Commit message: Deprecate MemoryResourceProvider

unread,

[L] Change in dart/sdk[main]: Deprecate MemoryResourceProvider.convertPath in favor of extension

Commit Queue submitted the change Change information Commit message: Deprecate MemoryResourceProvider

May 7

Paul Berry (Gerrit)

May 7

[S] Change in dart/sdk[main]: Prepare to publish analyzer 7.4.5

Attention needed from Konstantin Shcheglov Paul Berry voted and added 1 comment Votes added by Paul

unread,

[S] Change in dart/sdk[main]: Prepare to publish analyzer 7.4.5

Attention needed from Konstantin Shcheglov Paul Berry voted and added 1 comment Votes added by Paul

May 7

Lasse Nielsen (Gerrit), … Stephen Adams (Gerrit)6

May 7

[XL] Change in dart/sdk[main]: Add overflow checking to `Duration` constructor.

Attention needed from Lasse Nielsen Stephen Adams voted and added 5 comments Votes added by Stephen

unread,

[XL] Change in dart/sdk[main]: Add overflow checking to `Duration` constructor.

Attention needed from Lasse Nielsen Stephen Adams voted and added 5 comments Votes added by Stephen

May 7

Samuel Rawlins (Gerrit), … Brian Wilkerson (Gerrit)10

May 7

[L] Change in dart/sdk[main]: [analysis_server] Support assist CodeActions via Commands when the cl...

Attention needed from Danny Tuppeny and Samuel Rawlins Brian Wilkerson added 1 comment Patchset-level

unread,

[L] Change in dart/sdk[main]: [analysis_server] Support assist CodeActions via Commands when the cl...

Attention needed from Danny Tuppeny and Samuel Rawlins Brian Wilkerson added 1 comment Patchset-level

May 7

Ryan Macnak (Gerrit), … Brian Wilkerson (Gerrit)9

May 7

[XL] Change in dart/sdk[main]: [observatory] Migrate off dart:html to package:web.

Brian Wilkerson added 1 comment Patchset-level comments File-level comment, Patchset 12 (Latest):

unread,

[XL] Change in dart/sdk[main]: [observatory] Migrate off dart:html to package:web.

Brian Wilkerson added 1 comment Patchset-level comments File-level comment, Patchset 12 (Latest):

May 7

Ryan Macnak (Gerrit)

May 7

[M] Change in dart/sdk[main]: [test] Await closing server socket before reusing the same fixed port.

Attention needed from Brian Quinlan New activity on the change Open in Gerrit Related details

unread,

[M] Change in dart/sdk[main]: [test] Await closing server socket before reusing the same fixed port.

Attention needed from Brian Quinlan New activity on the change Open in Gerrit Related details

May 7

Brian Wilkerson (Gerrit), … Commit Queue (Gerrit)3

May 7

[S] Change in dart/sdk[main]: Issue 60683. Fix for UnimplementedError from ElementImpl2.enclosingEl...

Commit Queue submitted the change Change information Commit message: Issue 60683. Fix for

unread,

[S] Change in dart/sdk[main]: Issue 60683. Fix for UnimplementedError from ElementImpl2.enclosingEl...

Commit Queue submitted the change Change information Commit message: Issue 60683. Fix for

May 7

Ryan Macnak (Gerrit), Siva Annamalai (Gerrit)2

May 7

[M] Change in dart/sdk[main]: [dart:io] Use close_range when available during process spawning.

Attention needed from Brian Quinlan and Ryan Macnak Siva Annamalai voted and added 1 comment Votes

unread,

[M] Change in dart/sdk[main]: [dart:io] Use close_range when available during process spawning.

Attention needed from Brian Quinlan and Ryan Macnak Siva Annamalai voted and added 1 comment Votes

May 7

Ryan Macnak (Gerrit), … Commit Queue (Gerrit)3

May 7

[XS] Change in dart/sdk[main]: [gardening] Fix dart2js chrome observatory test.

Commit Queue submitted the change Change information Commit message: [gardening] Fix dart2js chrome

unread,

[XS] Change in dart/sdk[main]: [gardening] Fix dart2js chrome observatory test.

Commit Queue submitted the change Change information Commit message: [gardening] Fix dart2js chrome

May 7

Kallen Tu (Gerrit), Paul Berry (Gerrit)3

May 7

[S] Change in dart/sdk[main]: [analyzer] Clean up ErrorVerifier._checkForConstOrNewWithAbstractClass

Kallen Tu voted Commit-Queue+2 Commit-Queue +2 Open in Gerrit Related details Attention set is empty

unread,

[S] Change in dart/sdk[main]: [analyzer] Clean up ErrorVerifier._checkForConstOrNewWithAbstractClass

Kallen Tu voted Commit-Queue+2 Commit-Queue +2 Open in Gerrit Related details Attention set is empty

May 7

Deepak Aravind (Gerrit), … Brian Wilkerson (Gerrit)29

May 7

[L] Change in dart/sdk[main]: [ffi] Error on promoted types in varargs

Attention needed from Daco Harkes and Johnni Winther Deepak Aravind added 1 comment Patchset-level

unread,

[L] Change in dart/sdk[main]: [ffi] Error on promoted types in varargs

Attention needed from Daco Harkes and Johnni Winther Deepak Aravind added 1 comment Patchset-level

May 7

Konstantin Shcheglov (Gerrit), … Commit Queue (Gerrit)7

May 7

[L] Change in dart/sdk[main]: Elements. Update ElementDirective implementations to stop being fragm...

Commit Queue submitted the change Change information Commit message: Elements. Update

unread,

[L] Change in dart/sdk[main]: Elements. Update ElementDirective implementations to stop being fragm...

Commit Queue submitted the change Change information Commit message: Elements. Update

May 7

Daco Harkes (Gerrit), Michael Goderbauer (Gerrit)4

May 7

[M] Change in dart/sdk[main]: [vm/ffi] Inline Array.elements for performance

Attention needed from Michael Goderbauer Daco Harkes voted and added 1 comment Votes added by Daco

unread,

[M] Change in dart/sdk[main]: [vm/ffi] Inline Array.elements for performance

Attention needed from Michael Goderbauer Daco Harkes voted and added 1 comment Votes added by Daco

May 7

Ryan Macnak (Gerrit), … Commit Queue (Gerrit)4

May 7

[M] Change in dart/sdk[main]: Roll Clang from 0454dd8c48cd to 8c7a2ce01a77

Commit Queue submitted the change Change information Commit message: Roll Clang from 0454dd8c48cd to

unread,

[M] Change in dart/sdk[main]: Roll Clang from 0454dd8c48cd to 8c7a2ce01a77

Commit Queue submitted the change Change information Commit message: Roll Clang from 0454dd8c48cd to

May 7

Brian Wilkerson (Gerrit), … Commit Queue (Gerrit)4

May 7

[XL] Change in dart/sdk[main]: Make `nodeCovering` a method on `CompilationUnitImpl` rather than an ...

Commit Queue submitted the change Change information Commit message: Make `nodeCovering` a method on

unread,

[XL] Change in dart/sdk[main]: Make `nodeCovering` a method on `CompilationUnitImpl` rather than an ...

Commit Queue submitted the change Change information Commit message: Make `nodeCovering` a method on

May 7

Samuel Rawlins (Gerrit), … Commit Queue (Gerrit)6

May 7

[L] Change in dart/sdk[main]: [analysis_server] Update CodeActionsProducers to support either kind ...

Commit Queue submitted the change Unreviewed changes 1 is the latest approved patch-set. No files

unread,

[L] Change in dart/sdk[main]: [analysis_server] Update CodeActionsProducers to support either kind ...

Commit Queue submitted the change Unreviewed changes 1 is the latest approved patch-set. No files

May 7

Brian Wilkerson (Gerrit), … Commit Queue (Gerrit)5

May 7

[L] Change in dart/sdk[main]: [analysis_server] Extract computing CodeActions from the textDocument...

Commit Queue submitted the change Change information Commit message: [analysis_server] Extract

unread,

[L] Change in dart/sdk[main]: [analysis_server] Extract computing CodeActions from the textDocument...

Commit Queue submitted the change Change information Commit message: [analysis_server] Extract

May 7

Ryan Macnak (Gerrit), Alexander Aprelev (Gerrit)5

May 7

[M] Change in dart/sdk[main]: Rebalance isolate stress testing shards.

Ryan Macnak submitted the change Change information Commit message: Rebalance isolate stress testing

unread,

[M] Change in dart/sdk[main]: Rebalance isolate stress testing shards.

Ryan Macnak submitted the change Change information Commit message: Rebalance isolate stress testing

May 7

Alexander Aprelev (Gerrit), … Commit Queue (Gerrit)5

May 7

[XS] Change in dart/sdk[main]: [gardening] Fix trampoline near jump to far jump.

Commit Queue submitted the change Change information Commit message: [gardening] Fix trampoline near

unread,

[XS] Change in dart/sdk[main]: [gardening] Fix trampoline near jump to far jump.

Commit Queue submitted the change Change information Commit message: [gardening] Fix trampoline near

May 7

Samuel Rawlins (Gerrit), … Commit Queue (Gerrit)4

May 7

[S] Change in dart/sdk[main]: analyzer_utilities: change analysisOptionsContent.include to be a list.

Commit Queue submitted the change Change information Commit message: analyzer_utilities: change

unread,

[S] Change in dart/sdk[main]: analyzer_utilities: change analysisOptionsContent.include to be a list.

Commit Queue submitted the change Change information Commit message: analyzer_utilities: change

May 7

Brian Wilkerson (Gerrit)

May 7

[S] Change in dart/sdk[main]: [analyzer] Skip repeated equal yaml edit calculations

Attention needed from Jens Johansen Brian Wilkerson voted Code-Review+1 Code-Review +1 Open in Gerrit

unread,

[S] Change in dart/sdk[main]: [analyzer] Skip repeated equal yaml edit calculations

Attention needed from Jens Johansen Brian Wilkerson voted Code-Review+1 Code-Review +1 Open in Gerrit

May 7

Slava Egorov (Gerrit), … Commit Queue (Gerrit)8

May 7

[M] Change in dart/sdk[main]: [vm] Fix issues in SampleBlockProcessor

Commit Queue submitted the change Change information Commit message: [vm] Fix issues in

unread,

[M] Change in dart/sdk[main]: [vm] Fix issues in SampleBlockProcessor

Commit Queue submitted the change Change information Commit message: [vm] Fix issues in

May 7

	
		OSZAR »

Search

Clear search

Close search

Google apps

Main menu